-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow out of tree platforms to customize cursor values #44841
Conversation
This pull request was exported from Phabricator. Differential Revision: D58301970 |
Base commit: 3c3c687 |
This pull request was exported from Phabricator. Differential Revision: D58301970 |
Summary: Pull Request resolved: facebook#44841 Out of tree platforms like react-native-macos and react-native-windows may wish to support different cursor types than are currently supported in mobile React Native (currently only "auto" and "pointer"). Since the Cursor is applied on the BaseViewProps across all platforms, we need an extension point where a platform can inject it's own header for defining a cursor. This header will also have to include it's own implementation of `fromRawValue` to parse the cursor value from RawProps into the host platform implementation of Cursor. ## Changelog [Internal] Differential Revision: D58301970
This pull request was exported from Phabricator. Differential Revision: D58301970 |
Summary: Pull Request resolved: facebook#44841 Out of tree platforms like react-native-macos and react-native-windows may wish to support different cursor types than are currently supported in mobile React Native (currently only "auto" and "pointer"). Since the Cursor is applied on the BaseViewProps across all platforms, we need an extension point where a platform can inject it's own header for defining a cursor. This header will also have to include it's own implementation of `fromRawValue` to parse the cursor value from RawProps into the host platform implementation of Cursor. ## Changelog [Internal] Differential Revision: D58301970
Summary: Pull Request resolved: facebook#44841 Out of tree platforms like react-native-macos and react-native-windows may wish to support different cursor types than are currently supported in mobile React Native (currently only "auto" and "pointer"). Since the Cursor is applied on the BaseViewProps across all platforms, we need an extension point where a platform can inject it's own header for defining a cursor. This header will also have to include it's own implementation of `fromRawValue` to parse the cursor value from RawProps into the host platform implementation of Cursor. ## Changelog [Internal] Differential Revision: D58301970
This pull request was exported from Phabricator. Differential Revision: D58301970 |
This pull request has been merged in d3e3e2a. |
This pull request was successfully merged by @rozele in d3e3e2a. When will my fix make it into a release? | How to file a pick request? |
Summary:
This change adds native support in Fabric for the remaining CSS cursor style values as defined here: https://developer.mozilla.org/en-US/docs/Web/CSS/cursor. Please note, this functionality is simply for prop parsing capabilities in Fabric, which are shared across all platforms. This does not add any additional cursor behavior support to iOS or Android, and the Flow and TypeScript types for cursor style values are still limited to
auto
andpointer
.Changelog
[General][Added] Fabric prop parsing capabilities for all CSS cursor style values
Differential Revision: D58301970