Allow out of tree platforms to customize cursor values #44841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58301970 |
Base commit: 3c3c687 |
|
This pull request was exported from Phabricator. Differential Revision: D58301970 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jun 8, 2024
Summary: Pull Request resolved: facebook#44841 Out of tree platforms like react-native-macos and react-native-windows may wish to support different cursor types than are currently supported in mobile React Native (currently only "auto" and "pointer"). Since the Cursor is applied on the BaseViewProps across all platforms, we need an extension point where a platform can inject it's own header for defining a cursor. This header will also have to include it's own implementation of `fromRawValue` to parse the cursor value from RawProps into the host platform implementation of Cursor. ## Changelog [Internal] Differential Revision: D58301970
|
This pull request was exported from Phabricator. Differential Revision: D58301970 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44841 Out of tree platforms like react-native-macos and react-native-windows may wish to support different cursor types than are currently supported in mobile React Native (currently only "auto" and "pointer"). Since the Cursor is applied on the BaseViewProps across all platforms, we need an extension point where a platform can inject it's own header for defining a cursor. This header will also have to include it's own implementation of `fromRawValue` to parse the cursor value from RawProps into the host platform implementation of Cursor. ## Changelog [Internal] Differential Revision: D58301970
Summary: Pull Request resolved: facebook#44841 Out of tree platforms like react-native-macos and react-native-windows may wish to support different cursor types than are currently supported in mobile React Native (currently only "auto" and "pointer"). Since the Cursor is applied on the BaseViewProps across all platforms, we need an extension point where a platform can inject it's own header for defining a cursor. This header will also have to include it's own implementation of `fromRawValue` to parse the cursor value from RawProps into the host platform implementation of Cursor. ## Changelog [Internal] Differential Revision: D58301970
|
This pull request was exported from Phabricator. Differential Revision: D58301970 |
|
This pull request has been merged in d3e3e2a. |
|
This pull request was successfully merged by @rozele in d3e3e2a. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds native support in Fabric for the remaining CSS cursor style values as defined here: https://developer.mozilla.org/en-US/docs/Web/CSS/cursor. Please note, this functionality is simply for prop parsing capabilities in Fabric, which are shared across all platforms. This does not add any additional cursor behavior support to iOS or Android, and the Flow and TypeScript types for cursor style values are still limited to
autoandpointer.Changelog
[General][Added] Fabric prop parsing capabilities for all CSS cursor style values
Differential Revision: D58301970