Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN][GHA] Migrate the Prepare Release workflow #44833

Closed
wants to merge 1 commit into from
Closed

[RN][GHA] Migrate the Prepare Release workflow #44833

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

This change migrates the prepare_release workflow from CCI to GHA

Changelog:

[Internal] - Migrate from CCI to GHA

Test Plan:

Test on GHA

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 7, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/move-release-workflow branch 23 times, most recently from 474f15d to 26fe70f Compare June 7, 2024 14:32
@cipolleschi cipolleschi marked this pull request as ready for review June 7, 2024 14:32
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi commented Jun 7, 2024
View reviewed changes
.github/actions/prepare_release/action.yml Outdated
runs:
using: composite
steps:
- name: Yarn Install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this is the circleci job

@cipolleschi cipolleschi force-pushed the cipolleschi/move-release-workflow branch from 26fe70f to a8b342f Compare June 7, 2024 14:51
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/move-release-workflow branch from a8b342f to d76e214 Compare June 7, 2024 15:14
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Jun 7, 2024 •
edited

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,248,892 +2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,454,657 -22
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 01822eb
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/move-release-workflow branch from d76e214 to 7a9ab59 Compare June 10, 2024 10:49
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/move-release-workflow branch from 7a9ab59 to feee69d Compare June 10, 2024 13:16
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/move-release-workflow branch from feee69d to 46b6f05 Compare June 10, 2024 15:13
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 10, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 7ce5e56.

@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @cipolleschi in 7ce5e56.

When will my fix make it into a release? | How to file a pick request?

@NickGerleman
Copy link
Contributor

FYI @cipolleschi I am seeing a new failure on main that seems potentially related to this change: E.g. https://github.com/facebook/react-native/actions/runs/9452422456/job/26035889529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cipolleschi @facebook-github-bot @analysis-bot @NickGerleman