rncli.h -> autolinking.h #44829
Closed
rncli.h -> autolinking.h #44829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58284662 |
Summary: This is the final part of core autolinking: 1. I split RNGP into an `app-plugin` and a `settings-plugin`. This was necessary as the Gradle modules need to be loaded inside the settings.gradle.kts. 2. I've introduced a Settings Plugin to take care of either invoking the `config` command from CLI or receiving a file in input. 3. I've removed the former `RunAutolinkingConfigTask` as now the command is invoked inside the settings plugin 4. I've added hashing computed based on the lockfiles so we won't be re-executing teh `config` command if the lockfiles are not changed. 5. I've updated RN-Tester to use the core autolinking rather than manual linking for the 2 libraries it's using. Changelog:linking [Internal] [Changed] - RNGP - Autolinking. Add support for linking projects Differential Revision: D58190363
Summary: I was using PackageList2 temporarily as I was migrating to Core Autolinking. Now we can rename everything to `PackageList` to reduce the number of changes to the template for users. Changelog: [Internal] [Changed] - PackageList2 -> PackageList Differential Revision: D58284661
|
This pull request was exported from Phabricator. Differential Revision: D58284662 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebook#44829 Another renaming that now we can merge to make clear what's the intent of this header. Changelog: [Internal] [Changed] - rncli.h -> autolinking.h Differential Revision: D58284662
cortinico
force-pushed
the
export-D58284662
branch
from
5b6faf2
to
8c7bb3e
Compare
Summary: Pull Request resolved: facebook#44829 Another renaming that now we can merge to make clear what's the intent of this header. Changelog: [Internal] [Changed] - rncli.h -> autolinking.h Differential Revision: D58284662
cortinico
force-pushed
the
export-D58284662
branch
from
8c7bb3e
to
a9fba73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58284662 |
Base commit: dbdd4da |
|
This pull request was successfully merged by @cortinico in 6937c70. When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 6937c70. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Another renaming that now we can merge to make clear what's the intent of this header.
Changelog:
[Internal] [Changed] - rncli.h -> autolinking.h
Differential Revision: D58284662