Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getContentOriginOffset to know info about if call-site want transform or not #44822

Closed
wants to merge 1 commit into from

Conversation

realsoelynn
Copy link
Contributor

Summary:
Changelog: [Internal]

This is to make getContentOriginOffset to have includeTransform information passed during Layout computation.

Differential Revision: D58223380

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

@analysis-bot
Copy link

analysis-bot commented Jun 6, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,249,256 -18
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,454,733 -21
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c9d7774
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 6, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
@realsoelynn
Copy link
Contributor Author

This is a pre-req for this bugfix #44168

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 7, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 7, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

realsoelynn added a commit to realsoelynn/react-native that referenced this pull request Jun 11, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Breaking]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Reviewed By: NickGerleman

Differential Revision: D58223380
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58223380

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ce588db.

Copy link

This pull request was successfully merged by @realsoelynn in ce588db.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 12, 2024
…sform or not (facebook#44822)

Summary:
Pull Request resolved: facebook#44822

Changelog: [Internal]

This is to make `getContentOriginOffset` to have `includeTransform` information passed during Layout computation.

Differential Revision: D58223380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants