Fix broken scroll view caused by D58157667#44820
Closed
ingridwang wants to merge 1 commit into
Closed
Conversation
Summary: # Changelog [iOS][Fixed] Fixing scroll view breakage caused by facebook#44789 Differential Revision: D58260014
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58260014 |
Contributor
|
This pull request has been merged in f4b921c. |
|
This pull request was successfully merged by Ingrid Wang in f4b921c. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44820 # Changelog [iOS][Fixed] Fixing scroll view breakage caused by facebook#44789 Reviewed By: cipolleschi Differential Revision: D58260014 fbshipit-source-id: 375697f1103ba7794f572f490b409a1d27304e66
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Summary: Fixes #46918 . break change comes from #44820 and #44789 . ## Changelog: [IOS] [FIXED] - Fixes scrollIndicatorInsets not work in old arch Pull Request resolved: #46944 Test Plan: scrollIndicatorInsets should work in old arch. Reviewed By: philIip Differential Revision: D64173490 Pulled By: cipolleschi fbshipit-source-id: f7186439146d1b811c02e584fd1d94fcbb5d88a2
joemun
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 11, 2025
Summary: Fixes facebook#46918 . break change comes from facebook#44820 and facebook#44789 . ## Changelog: [IOS] [FIXED] - Fixes scrollIndicatorInsets not work in old arch Pull Request resolved: facebook#46944 Test Plan: scrollIndicatorInsets should work in old arch. Reviewed By: philIip Differential Revision: D64173490 Pulled By: cipolleschi fbshipit-source-id: f7186439146d1b811c02e584fd1d94fcbb5d88a2
joemun
pushed a commit
to discord/react-native
that referenced
this pull request
Jan 16, 2025
Summary: Fixes facebook#46918 . break change comes from facebook#44820 and facebook#44789 . ## Changelog: [IOS] [FIXED] - Fixes scrollIndicatorInsets not work in old arch Pull Request resolved: facebook#46944 Test Plan: scrollIndicatorInsets should work in old arch. Reviewed By: philIip Differential Revision: D64173490 Pulled By: cipolleschi fbshipit-source-id: f7186439146d1b811c02e584fd1d94fcbb5d88a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog
[iOS][Fixed] Fixing scroll view breakage caused by #44789
Differential Revision: D58260014