Updating eslint packages to flat config file #43959

MCanhisares · 2024-04-08T03:30:09Z

Summary:

Implements eslint flat config file support

Changelog:

[GENERAL] [ADDED] - Adding support for Flat Config files

Test Plan:

Run lint on a reproducer with the eslint config changes
Reproducer example: https://github.com/MCanhisares/eslint-flat-upgrade

analysis-bot · 2024-04-08T03:59:48Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,558,636	+0
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,928,758	-4
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 3f17c8b
Branch: main

jafar-jabr · 2024-05-01T11:02:47Z

@MCanhisares Is there any chance that this will be merged soon ?

MCanhisares · 2024-05-11T23:30:30Z

@cortinico what do we have to do to get this ready for merge?

Edit: To add more context, the JS tasks are failing because the eslint server is using the latest version of this package which should be ready for the new config format. Should we fix these issues in this PR? Or open another PR to handle the changes to the main proj?

Jonnboy91 · 2024-06-12T12:02:29Z

Any update on this?

robhogan · 2024-06-12T16:50:34Z

LGTM on the face of it, importing to test inside the FB monorepo.

We should bump the template devDependency to ^8.23.0 as well though - I'll add that.

facebook-github-bot · 2024-06-12T16:51:24Z

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robhogan

Hi @MCanhisares - thanks for this and sorry it's been in review for so long. Having had a closer look, this seems to break support for legacy config - this is actually the error CI is correctly reporting, and also came up importing to the internal monorepo - it requires users to update their projects to use flat config.

I think that's too much upgrade friction, and also presumably unintentional from the PR description - we should be able to support flat config without breaking legacy just yet, as eg jsx-eslint/eslint-plugin-react#3429 did.

…nstructions for flat config files

boorad · 2024-08-11T16:56:28Z

packages/eslint-config-react-native/README.md

+
+| Eslint version       | `.eslintrc` support | `eslint.config.js` support |
+| :------------------- | :-----------------: | :------------------------: |
+| `>= 9.0.0`           | ❌                  | ❌                         |


green check in eslint.config.js column here?

MCanhisares · 2024-08-15T05:12:16Z

Hi @MCanhisares - thanks for this and sorry it's been in review for so long. Having had a closer look, this seems to break support for legacy config - this is actually the error CI is correctly reporting, and also came up importing to the internal monorepo - it requires users to update their projects to use flat config.

I think that's too much upgrade friction, and also presumably unintentional from the PR description - we should be able to support flat config without breaking legacy just yet, as eg jsx-eslint/eslint-plugin-react#3429 did.

Hi @robhogan, sorry this took a while to get back to, but I made the changes to support both legacy and new flat config formats

In order for this to work though, we need to change our approach for the configs, and export one that supports legacy .eslintrc projects and one for projects that use the new format (confirmed by one of the core eslint maintainers ).

Another problem arises from this, where eslint reads the package name to create an alias to the config itself, so we have two alternatives:

Move away from the current package structure, and distribute the configs on the react-native-eslint-plugin package (seems like the better option, and is what the react, angular, solid and many others do)
Create a new package eslint-config-react-native-flat and publish it so other projects can use the new config format.

The current code is uses approach 1, but I can easily migrate to 2 if you think it makes more sense

Let me know what you think, and also the tests might need to be updated to correctly read the new eslint configs. Where should I make those changes?

theo-mesnil · 2024-10-19T15:00:53Z

Hi, can we merge this soon? We can't use eslint 9 for now. Thanks 🙏🏻

mshima · 2024-11-15T13:38:15Z

2. Create a new package eslint-config-react-native-flat and publish it so other projects can use the new config format.

My suggestion is to create a new package called @react-native/eslint.
It’s not really a plugin, it’s a pre-defined config recommendation.

YowaiCoder · 2025-03-27T15:33:16Z

It's been almost a year, guess we‘ll never get there. 😂

kraenhansen · 2025-04-11T07:09:49Z

packages/eslint-plugin-react-native/README.md

+const reactNative = require('@react-native/eslint-plugin');  
+const myplugin = require('my-plugin');
+
+module.exports = [
+  ...reactNative.configs.flat,
+  {
+    plugins: {
+       myplugin    
+    },
+    ...
+  },
+];


Could this example use ESM?

kraenhansen · 2025-04-11T07:19:00Z

I would love to see this PR get some more 💙 and attention.

@MCanhisares I know it's been a while, but I have a few clarifying questions towards your last comment.

In order for this to work though, we need to change our approach for the configs, and export one that supports legacy .eslintrc projects and one for projects

Does the PR in it's current state reflect this? Or is that an outstanding task?

Another problem arises from this, where eslint reads the package name to create an alias to the config itself,

When is this an issue?

the tests might need to be updated to correctly read the new eslint configs

Do you need any help with this?

react-native-bot · 2025-10-09T05:01:06Z

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

pipopotamasu · 2025-10-28T11:46:42Z

I created the PR for Flat Config support because this PR is stale and doesn't seem likely to move forward

#54297

MCanhisares · 2025-11-04T22:29:43Z

I created the PR for Flat Config support because this PR is stale and doesn't seem likely to move forward

#54297

Glad you were able to figure out a solution and the maintainers responded to the PR - as soon as it's merged I'll close this one

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024

MCanhisares changed the title ~~Updating eslint packages to flat file~~ Updating eslint packages to flat config file Apr 8, 2024

MCanhisares marked this pull request as ready for review April 8, 2024 21:02

MCanhisares mentioned this pull request Apr 8, 2024

eslint-config/eslint-plugin: Support "Flat Config" (ESLint 9) #42996

Open

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 8, 2024

robhogan requested changes Jun 14, 2024

View reviewed changes

MCanhisares added 2 commits August 8, 2024 21:24

Updating eslint packages to flat file

d4e7d00

Updating commented eslint flags, updating readme with more detailed i…

fa9fccd

…nstructions for flat config files

MCanhisares force-pushed the feat/eslint-flat-config branch from c16e55c to fa9fccd Compare August 9, 2024 01:24

boorad reviewed Aug 11, 2024

View reviewed changes

Migrating config to eslint plugin

e2badfd

MCanhisares force-pushed the feat/eslint-flat-config branch from 10afaf3 to e2badfd Compare August 15, 2024 03:43

Migrating config to eslint plugin

b2d7397

cortinico requested a review from robhogan August 15, 2024 10:00

coolsoftwaretyler mentioned this pull request Jan 11, 2025

fix: simplify ESLint config to improve dependency management infinitered/ignite#2883

Merged

5 tasks

JoshuaKGoldberg mentioned this pull request Mar 24, 2025

📈 Tracking: Flat Config support eslint/eslint#18093

Closed

39 tasks

kraenhansen reviewed Apr 11, 2025

View reviewed changes

react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 9, 2025

react-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 9, 2025

pipopotamasu mentioned this pull request Nov 8, 2025

Add support for Flat Config (eslint v9) #54297

Closed

MCanhisares closed this Nov 27, 2025

Updating eslint packages to flat config file #43959

Updating eslint packages to flat config file #43959

Uh oh!

Conversation

MCanhisares commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

analysis-bot commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jafar-jabr commented May 1, 2024

Uh oh!

MCanhisares commented May 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jonnboy91 commented Jun 12, 2024

Uh oh!

robhogan commented Jun 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 12, 2024

Uh oh!

robhogan left a comment

Choose a reason for hiding this comment

Uh oh!

boorad Aug 11, 2024

Choose a reason for hiding this comment

Uh oh!

MCanhisares commented Aug 15, 2024

Uh oh!

theo-mesnil commented Oct 19, 2024

Uh oh!

mshima commented Nov 15, 2024

Uh oh!

YowaiCoder commented Mar 27, 2025

Uh oh!

kraenhansen Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

kraenhansen commented Apr 11, 2025

Uh oh!

react-native-bot commented Oct 9, 2025

Uh oh!

pipopotamasu commented Oct 28, 2025

Uh oh!

MCanhisares commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

MCanhisares commented Apr 8, 2024 •

edited

Loading

analysis-bot commented Apr 8, 2024 •

edited

Loading

MCanhisares commented May 11, 2024 •

edited

Loading

robhogan commented Jun 12, 2024 •

edited

Loading