Add ReactRootViewTagGenerator #43882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55772580 |
Base commit: 5927165 |
|
This pull request was exported from Phabricator. Differential Revision: D55772580 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 4, 2024
Summary: Pull Request resolved: facebook#43882 Changelog: [Added] Add ReactRootViewTagGenerator This copies over a modified version of the [react-native-windows](https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Modules/ReactRootViewTagGenerator.h) implementation so it can be shared with other C based platforms This also updates the outdated comment about the non existing ReactIOSTagHandles JS module. Differential Revision: D55772580
christophpurrer
force-pushed
the
export-D55772580
branch
from
8086864
to
49da52e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55772580 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 4, 2024
Summary: Pull Request resolved: facebook#43882 Changelog: [Added] Add ReactRootViewTagGenerator This copies over a modified version of the [react-native-windows](https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Modules/ReactRootViewTagGenerator.h) implementation so it can be shared with other C based platforms This also updates the outdated comment about the non existing ReactIOSTagHandles JS module. Differential Revision: D55772580
christophpurrer
force-pushed
the
export-D55772580
branch
from
49da52e
to
0925e9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55772580 |
christophpurrer
force-pushed
the
export-D55772580
branch
from
0925e9b
to
44e44d7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43882 Changelog: [Added] Add ReactRootViewTagGenerator This copies over a modified version of the [react-native-windows](https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Modules/ReactRootViewTagGenerator.h) implementation so it can be shared with other C based platforms This also updates the outdated comment about the non existing ReactIOSTagHandles JS module. Differential Revision: D55772580
|
This pull request was exported from Phabricator. Differential Revision: D55772580 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43882 Changelog: [Added] Add ReactRootViewTagGenerator This copies over a modified version of the [react-native-windows](https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Modules/ReactRootViewTagGenerator.h) implementation so it can be shared with other C based platforms This also updates the outdated comment about the non existing ReactIOSTagHandles JS module. Differential Revision: D55772580
christophpurrer
force-pushed
the
export-D55772580
branch
from
44e44d7
to
b5bc2ad
Compare
Summary: Pull Request resolved: facebook#43882 Changelog: [Added] Add ReactRootViewTagGenerator This copies over a modified version of the [react-native-windows](https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Modules/ReactRootViewTagGenerator.h) implementation so it can be shared with other C based platforms This also updates the outdated comment about the non existing ReactIOSTagHandles JS module. Differential Revision: D55772580
|
This pull request was exported from Phabricator. Differential Revision: D55772580 |
christophpurrer
force-pushed
the
export-D55772580
branch
from
b5bc2ad
to
a8b7b75
Compare
|
This pull request has been merged in 7dec625. |
|
This pull request was successfully merged by @christophpurrer in 7dec625. When will my fix make it into a release? | How to file a pick request? |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 9, 2024
Summary: This builds upon facebook#43882 and re-uses the C++ ReactRootViewTagGenerator for RN-iOS Changelog: [Internal] Differential Revision: D55876627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Added] Add ReactRootViewTagGenerator
This copies over a modified version of the react-native-windows implementation so it can be shared with other C based platforms
This also updates the outdated comment about the non existing ReactIOSTagHandles JS module.
Differential Revision: D55772580