-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
//xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/clipboard:clipboardAndroid #43861
Conversation
This pull request was exported from Phabricator. Differential Revision: D55725451 |
…/main/java/com/facebook/react/modules/clipboard:clipboardAndroid (facebook#43861) Summary: Pull Request resolved: facebook#43861 Changelog: [Internal] _____ ## Why? We recommend to use Kotlin for any new code and are actively migrating Java code to Kotlin. This codemod service attempts to migrate existing Java code to Kotlin. ## How was this diff generated? This codemod service scans through qualified paths and looks for Java modules. Then it runs `kotlinator.sh` on each module, which generated this diff. ## What if I see problems in this diff? We recommend commandeering and fixing the diff. If you reject or abandon the diff, the codemod service will regenerate it in a few days - Script for easily commandeer & open diff: In fbandroid, `scripts/commandeer_and_checkout.sh <DIFF>`. It not only commandeer the diff, but also rebase & open diff in Android Studio. - Report repeating issues in [Kotlinator Papercut](https://fburl.com/papercuts/1g4f4qas) See more useful tips & scripts in [Kotlin Auto-Conversion Codemod Wiki](https://fburl.com/wiki/c68ka0pu) _____ ## Questions / Comments / Feedback? **Your feedback is important to us! Give feedback about this diff by clicking the "Provide Feedback" button below.** * Returning back to author or abandoning this diff will only cause the diff to be regenerated in the future. * Do **NOT** post in the CodemodService Feedback group about this specific diff. _____ ## Codemod Metadata NOTE: You won't need to read this section to review this diff. https://www.internalfb.com/intern/sandcastle/job/22517999373069959/ |Oncall|[kotlin_in_fb4a](https://our.intern.facebook.com/intern/oncall3/?shortname=kotlin_in_fb4a)| |CodemodConfig|[fbsource/kotlinator.json](https://www.internalfb.com/codemod_service/fbsource%2Fkotlinator.json)| |ConfigType|configerator| Rules run: - CodemodTransformerFBSourceScript This diff was created with [CodemodService](https://fburl.com/CodemodService). Differential Revision: D55725451
eb00a7a
to
aee8aec
Compare
This pull request was exported from Phabricator. Differential Revision: D55725451 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D55725451 |
…/main/java/com/facebook/react/modules/clipboard:clipboardAndroid (facebook#43861) Summary: Pull Request resolved: facebook#43861 Changelog: [Internal] _____ ## Why? We recommend to use Kotlin for any new code and are actively migrating Java code to Kotlin. This codemod service attempts to migrate existing Java code to Kotlin. ## How was this diff generated? This codemod service scans through qualified paths and looks for Java modules. Then it runs `kotlinator.sh` on each module, which generated this diff. ## What if I see problems in this diff? We recommend commandeering and fixing the diff. If you reject or abandon the diff, the codemod service will regenerate it in a few days - Script for easily commandeer & open diff: In fbandroid, `scripts/commandeer_and_checkout.sh <DIFF>`. It not only commandeer the diff, but also rebase & open diff in Android Studio. - Report repeating issues in [Kotlinator Papercut](https://fburl.com/papercuts/1g4f4qas) See more useful tips & scripts in [Kotlin Auto-Conversion Codemod Wiki](https://fburl.com/wiki/c68ka0pu) _____ ## Questions / Comments / Feedback? **Your feedback is important to us! Give feedback about this diff by clicking the "Provide Feedback" button below.** * Returning back to author or abandoning this diff will only cause the diff to be regenerated in the future. * Do **NOT** post in the CodemodService Feedback group about this specific diff. _____ ## Codemod Metadata NOTE: You won't need to read this section to review this diff. https://www.internalfb.com/intern/sandcastle/job/22517999373069959/ |Oncall|[kotlin_in_fb4a](https://our.intern.facebook.com/intern/oncall3/?shortname=kotlin_in_fb4a)| |CodemodConfig|[fbsource/kotlinator.json](https://www.internalfb.com/codemod_service/fbsource%2Fkotlinator.json)| |ConfigType|configerator| Rules run: - CodemodTransformerFBSourceScript This diff was created with [CodemodService](https://fburl.com/CodemodService). Reviewed By: cortinico Differential Revision: D55725451
aee8aec
to
ecd854c
Compare
Base commit: 3422dcf |
…/main/java/com/facebook/react/modules/clipboard:clipboardAndroid (facebook#43861) Summary: Pull Request resolved: facebook#43861 Changelog: [Internal] _____ ## Why? We recommend to use Kotlin for any new code and are actively migrating Java code to Kotlin. This codemod service attempts to migrate existing Java code to Kotlin. ## How was this diff generated? This codemod service scans through qualified paths and looks for Java modules. Then it runs `kotlinator.sh` on each module, which generated this diff. ## What if I see problems in this diff? We recommend commandeering and fixing the diff. If you reject or abandon the diff, the codemod service will regenerate it in a few days - Script for easily commandeer & open diff: In fbandroid, `scripts/commandeer_and_checkout.sh <DIFF>`. It not only commandeer the diff, but also rebase & open diff in Android Studio. - Report repeating issues in [Kotlinator Papercut](https://fburl.com/papercuts/1g4f4qas) See more useful tips & scripts in [Kotlin Auto-Conversion Codemod Wiki](https://fburl.com/wiki/c68ka0pu) _____ ## Questions / Comments / Feedback? **Your feedback is important to us! Give feedback about this diff by clicking the "Provide Feedback" button below.** * Returning back to author or abandoning this diff will only cause the diff to be regenerated in the future. * Do **NOT** post in the CodemodService Feedback group about this specific diff. _____ ## Codemod Metadata NOTE: You won't need to read this section to review this diff. https://www.internalfb.com/intern/sandcastle/job/22517999373069959/ |Oncall|[kotlin_in_fb4a](https://our.intern.facebook.com/intern/oncall3/?shortname=kotlin_in_fb4a)| |CodemodConfig|[fbsource/kotlinator.json](https://www.internalfb.com/codemod_service/fbsource%2Fkotlinator.json)| |ConfigType|configerator| Rules run: - CodemodTransformerFBSourceScript This diff was created with [CodemodService](https://fburl.com/CodemodService). Reviewed By: cortinico Differential Revision: D55725451
This pull request was exported from Phabricator. Differential Revision: D55725451 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D55725451 |
ecd854c
to
6efc4fd
Compare
This pull request was successfully merged by @andrewdacenko in 2c68019. When will my fix make it into a release? | How to file a pick request? |
Summary:
Changelog: [Internal]
Why?
We recommend to use Kotlin for any new code and are actively migrating Java code to Kotlin. This codemod service attempts to migrate existing Java code to Kotlin.
How was this diff generated?
This codemod service scans through qualified paths and looks for Java modules. Then it runs
kotlinator.sh
on each module, which generated this diff.What if I see problems in this diff?
We recommend commandeering and fixing the diff. If you reject or abandon the diff, the codemod service will regenerate it in a few days
scripts/commandeer_and_checkout.sh <DIFF>
. It not only commandeer the diff, but also rebase & open diff in Android Studio.See more useful tips & scripts in Kotlin Auto-Conversion Codemod Wiki
Questions / Comments / Feedback?
Your feedback is important to us! Give feedback about this diff by clicking the "Provide Feedback" button below.
Codemod Metadata
NOTE: You won't need to read this section to review this diff.
https://www.internalfb.com/intern/sandcastle/job/22517999373069959/
|Oncall|kotlin_in_fb4a|
|CodemodConfig|fbsource/kotlinator.json|
|ConfigType|configerator|
Rules run:
This diff was created with CodemodService.
Differential Revision: D55725451