//xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/sound:soundAndroid #43860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55725322 |
…/main/java/com/facebook/react/modules/sound:soundAndroid (facebook#43860) Summary: Pull Request resolved: facebook#43860 Changelog: [Internal] _____ ## Why? We recommend to use Kotlin for any new code and are actively migrating Java code to Kotlin. This codemod service attempts to migrate existing Java code to Kotlin. ## How was this diff generated? This codemod service scans through qualified paths and looks for Java modules. Then it runs `kotlinator.sh` on each module, which generated this diff. ## What if I see problems in this diff? We recommend commandeering and fixing the diff. If you reject or abandon the diff, the codemod service will regenerate it in a few days - Script for easily commandeer & open diff: In fbandroid, `scripts/commandeer_and_checkout.sh <DIFF>`. It not only commandeer the diff, but also rebase & open diff in Android Studio. - Report repeating issues in [Kotlinator Papercut](https://fburl.com/papercuts/1g4f4qas) See more useful tips & scripts in [Kotlin Auto-Conversion Codemod Wiki](https://fburl.com/wiki/c68ka0pu) _____ ## Questions / Comments / Feedback? **Your feedback is important to us! Give feedback about this diff by clicking the "Provide Feedback" button below.** * Returning back to author or abandoning this diff will only cause the diff to be regenerated in the future. * Do **NOT** post in the CodemodService Feedback group about this specific diff. _____ ## Codemod Metadata NOTE: You won't need to read this section to review this diff. https://www.internalfb.com/intern/sandcastle/job/1239557953/ |Oncall|[kotlin_in_fb4a](https://our.intern.facebook.com/intern/oncall3/?shortname=kotlin_in_fb4a)| |CodemodConfig|[fbsource/kotlinator.json](https://www.internalfb.com/codemod_service/fbsource%2Fkotlinator.json)| |ConfigType|configerator| Rules run: - CodemodTransformerFBSourceScript This diff was created with [CodemodService](https://fburl.com/CodemodService). Differential Revision: D55725322
andrewdacenko
force-pushed
the
export-D55725322
branch
from
80e01d4
to
8e63264
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55725322 |
Base commit: 9c00d6d |
|
This pull request has been merged in 092ed2f. |
|
This pull request was successfully merged by @andrewdacenko in 092ed2f. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Why?
We recommend to use Kotlin for any new code and are actively migrating Java code to Kotlin. This codemod service attempts to migrate existing Java code to Kotlin.
How was this diff generated?
This codemod service scans through qualified paths and looks for Java modules. Then it runs
kotlinator.shon each module, which generated this diff.What if I see problems in this diff?
We recommend commandeering and fixing the diff. If you reject or abandon the diff, the codemod service will regenerate it in a few days
scripts/commandeer_and_checkout.sh <DIFF>. It not only commandeer the diff, but also rebase & open diff in Android Studio.See more useful tips & scripts in Kotlin Auto-Conversion Codemod Wiki
Questions / Comments / Feedback?
Your feedback is important to us! Give feedback about this diff by clicking the "Provide Feedback" button below.
Codemod Metadata
NOTE: You won't need to read this section to review this diff.
https://www.internalfb.com/intern/sandcastle/job/1239557953/
|Oncall|kotlin_in_fb4a|
|CodemodConfig|fbsource/kotlinator.json|
|ConfigType|configerator|
Rules run:
This diff was created with CodemodService.
Differential Revision: D55725322