Convert ReactModalHostManager to Kotlin #43844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55739386 |
Base commit: bc832ca |
|
This pull request was exported from Phabricator. Differential Revision: D55739386 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 4, 2024
Summary: Pull Request resolved: facebook#43844 This converts the last class inside `com.facebook.react.views.modal` to Kotlin Changelog: [Internal] [Changed] - Convert ReactModalHostManager to Kotlin Reviewed By: javache Differential Revision: D55739386
cortinico
force-pushed
the
export-D55739386
branch
from
60f7615
to
eb901f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55739386 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43844 This converts the last class inside `com.facebook.react.views.modal` to Kotlin Changelog: [Internal] [Changed] - Convert ReactModalHostManager to Kotlin Reviewed By: javache Differential Revision: D55739386
cortinico
force-pushed
the
export-D55739386
branch
from
eb901f5
to
9e03853
Compare
Summary: This class is quite legacy and requires a couple of eyes before merging it. I've tested that modals are working fine on RN-Tester both Old & New Arch. Changelog: [Internal] [Changed] - ReactModalHostView to Kotlin Differential Revision: D55739128
Summary: Pull Request resolved: facebook#43844 This converts the last class inside `com.facebook.react.views.modal` to Kotlin Changelog: [Internal] [Changed] - Convert ReactModalHostManager to Kotlin Reviewed By: javache Differential Revision: D55739386
|
This pull request was exported from Phabricator. Differential Revision: D55739386 |
cortinico
force-pushed
the
export-D55739386
branch
from
9e03853
to
0637715
Compare
|
This pull request has been merged in ed41067. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This converts the last class inside
com.facebook.react.views.modalto KotlinChangelog:
[Internal] [Changed] - Convert ReactModalHostManager to Kotlin
Differential Revision: D55739386