-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN][iOS] Adjust InputAccessoryView width to match device width within Safe Area constraints #43303
[RN][iOS] Adjust InputAccessoryView width to match device width within Safe Area constraints #43303
Conversation
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
2dab3c8
to
cbf6528
Compare
Base commit: 9066308 |
cbf6528
to
07ec30f
Compare
07ec30f
to
f3e45a9
Compare
Thanks for the contribution @mauriciomeirelles and sorry for the late reply: I have been out for some weeks and I missed this. |
Hi @mauriciomeirelles, can you please split the contribution in two parts? One for the Safe Area and one for the I'm a bit reluctant with the change as it might break a lot of internal tests and product, unfortunately... But we can try. |
Sure! |
3ef8119
to
da29ccb
Compare
Hey @cipolleschi, I've just updated the PR to remove the breaking change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauriciomeirelles thanks for updating the PR.
Left a question. Also, we should update the title as now the PR is more like: [RN][iOS] Ensure InputAccessoryView respect SafeArea.
What do you think?
packages/react-native/Libraries/Components/TextInput/InputAccessoryView.js
Outdated
Show resolved
Hide resolved
da29ccb
to
dea98c6
Compare
dea98c6
to
d95e956
Compare
…e Area constraints
d95e956
to
6884216
Compare
hey @cipolleschi, I've updated the PR! Let me know what you think! |
Code looks good. |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cipolleschi merged this pull request in 8597727. |
This pull request was successfully merged by @mauriciomeirelles in 8597727. When will my fix make it into a release? | How to file a pick request? |
Summary:
This PR updates the
InputAccessoryView
component to improve its width handling during device orientation changes for both Fabric and the old renderer. With this update, the component will always occupy the full width of the screen and adjust its size when the device orientation changes.It also updates the component to stick to the safe area in React Native instead of iOS native. This tweak opens up possibilities for better customizations down the line.
Resolves: #27887
Changelog:
[IOS] [FIXED] - Fix
InputAccessoryView
width on device orientation changeTest Plan:
fix_inputaccessoryview_width.mov
Difference between horizontal list with horizontal safe area inset in the component or on the content
component_contraint.mov
content_inset.mov