Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native-test-library package #43068

Closed
wants to merge 1 commit into from

Conversation

dmytrorykun
Copy link
Contributor

@dmytrorykun dmytrorykun commented Feb 16, 2024

Summary:
This diff adds react-native-test-library package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the OSS Library Example screen.

{F1457510909}

Change Background tests native commands.
Set Opacity tests native props.
Get Random Number tests native module.

Changelog: [Internal]

Differential Revision: D50793835

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

s.license = package['license']
s.platforms = min_supported_versions
s.author = 'Meta Platforms, Inc. and its affiliates'
s.source = { :git => package['repository'], :tag => '#{s.version}' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "#{s.version}" or just simply s.version.

Suggested change
s.source = { :git => package['repository'], :tag => '#{s.version}' }
s.source = { :git => package['repository'], :tag => s.version }

Copy link
Contributor

@dcangulo dcangulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a string interpolation typo.

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Feb 16, 2024
Summary:

This diff adds `react-native-oss-library-example` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Feb 16, 2024
Summary:

This diff adds `react-native-oss-library-example` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Feb 16, 2024
Summary:

This diff adds `react-native-oss-library-example` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Differential Revision: D50793835
@dmytrorykun dmytrorykun changed the title Add react-native-oss-library-example package Add react-native-test-library package Feb 16, 2024
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Feb 16, 2024
Summary:

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Apr 5, 2024
Summary:
Pull Request resolved: facebook#43068

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Apr 5, 2024
Summary:
Pull Request resolved: facebook#43068

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43068

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D50793835
@analysis-bot
Copy link

analysis-bot commented Apr 8, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,400,775 +182,894
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,776,153 +181,526
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b23960a
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43068

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43068

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43068

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D50793835
Summary:
Pull Request resolved: facebook#43068

This diff adds `react-native-test-library` package.
It contains native module and native component example, and targets both the new and the old architecture. It has structure similar to many OSS React Native libraries, and is supposed to be used to test the integration with third-party libraries.

It is integrated with RNTester as the **OSS Library Example** screen.

{F1457510909}

**Change Background** tests native commands.
**Set Opacity** tests native props.
**Get Random Number** tests native module.

Changelog: [Internal]

Reviewed By: RSNara

Differential Revision: D50793835
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50793835

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1cb0a33.

Copy link

github-actions bot commented Apr 9, 2024

This pull request was successfully merged by @dmytrorykun in 1cb0a33.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants