[iOS] Fix release build error due to a casing issue in hermes tarball path after download prebuilt tarball

[wfern]

Summary:

In my mac, I use a case-sensitive volume and when I build a react-native 0.73 project it failed with an error that can't find the hermes release tarball to extract:

Node found at: /usr/local/bin/node
Preparing the final location
Extracting the tarball
tar: Error opening archive: Failed to open '/Volumes/Workspace/meet-art-link/ios/Pods/hermes-engine-artifacts/hermes-ios-0.73.1-Release.tar.gz'

Note the ...-Release.tar.gz in the error. In the disk it's ...-release.tar.gz.

The build fails in after download the release tarball in release mode because the hermes tarball name in the replace_hermes_version.js build script is capitalized, while the file is lowercase on disk.

The fix is to ensure the hermes tarball name's "build type" is lowercase just like the function that creates the tarballs in react-native release located in hermes_utils.js in getHermesPrebuiltArtifactsTarballName().

Perhaps it's better to retrieve the tarball name from the same method it's generated? E.g.:

const { getHermesPrebuiltArtifactsTarballName } = require('react-native/scripts/hermes/hermes-utils');

const tarballName = getHermesPrebuiltArtifactsTarballName(`${version}-${configuration}`);
const tarballURLPath = `${podsRoot}/hermes-engine-artifacts/${tarballName}`;

If yes, let me know to update the PR.

Changelog:

[iOS][Fixed] - Fix release build error due to a casing issue in hermes tarball path after download prebuilt tarball

Test Plan:

Use a case sensitive volume or system and build react-native 0.73 in release mode, it will fail. Apply the patch in this PR and it will work fine.

[facebook-github-bot]

Hi @wfern!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

Thank you for opening this PR and fixing this issue.
I left a comment on lowercasing the version. I don't think it is required, because the versions usually have only numbers and dots. The only exception is for RCs, so it might make sense to keep the lowercase.

[cipolleschi]

I don't think we have to lower case the version, or am I missing something?

[wfern]

In stable versions it is really not necessary but I added it for 2 reasons:

1. Because of the .RC versions as you said and I saw in the issue: iOS Release build from XCode fails at "[CP-User] [Hermes] Replace Hermes for the right configuration, if needed" step after adding a package #39903 some people having this same error and it could be because of this issue.
2. The method that generates the files in hermes_utils.js reduces the entire value including the version. So I think it really affects RC versions.

[cipolleschi]

Thank you for opening this PR and fixing this issue.
I left a comment on lowercasing the version. I don't think it is required, because the versions usually have only numbers and dots. The only exception is for RCs, so it might make sense to keep the lowercase.

[facebook-github-bot]

@cipolleschi merged this pull request in 2e2f8a6.