Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN: Remove Deprecated Prop Types #42019

Closed
wants to merge 1 commit into from

Conversation

yungsters
Copy link
Contributor

Summary:
Removes the following deprecated properties from React Native:

  • Image.propTypes
  • Text.propTypes
  • TextInput.propTypes
  • ColorPropType
  • EdgeInsetsPropType
  • PointPropType
  • ViewPropTypes

The deprecation history for these prop types is not super obvious, so here is a summary:

We believe that by the next public release, enough time will have passed for the community to be able to upgrade without patching React Native or otherwise working around the removal of these deprecated prop types.

If anyone has trouble identifying the source of a deleted prop types usage, please file an issue so we can help track it down with you.

Changelog:
[General][Removed] - Removed deprecated prop types

Differential Revision: D52337762

Summary:
Removes the following deprecated properties from React Native:

- `Image.propTypes`
- `Text.propTypes`
- `TextInput.propTypes`
- `ColorPropType`
- `EdgeInsetsPropType`
- `PointPropType`
- `ViewPropTypes`

The deprecation history for these prop types is not super obvious, so here is a summary:

- `[email protected]` extracted `prop-types` into a separate package to reflect that not everybody uses them.
- `[email protected]` added a deprecation warning to built-in prop types. (facebook@3f62904)
- `[email protected]` removed built-in prop types. (facebook@3e229f2)
- `[email protected]` restored built-in prop types, along with bug fixes to isolate deprecated usage. (facebook@b966d29)

We believe that by the next public release, enough time will have passed for the community to be able to upgrade without patching React Native or otherwise working around the removal of these deprecated prop types.

**If anyone has trouble identifying the source of a deleted prop types usage, please file an issue so we can help track it down with you.**

Changelog:
[General][Removed] - Removed deprecated prop types

Differential Revision: D52337762
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52337762

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,576,055 -8,581
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,949,872 -9,600
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: dae4a11
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 21, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 228cb80.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#42019

Removes the following deprecated properties from React Native:

- `Image.propTypes`
- `Text.propTypes`
- `TextInput.propTypes`
- `ColorPropType`
- `EdgeInsetsPropType`
- `PointPropType`
- `ViewPropTypes`

The deprecation history for these prop types is not super obvious, so here is a summary:

- `[email protected]` extracted `prop-types` into a separate package to reflect that not everybody uses them.
- `[email protected]` added a deprecation warning to built-in prop types. (facebook@3f62904)
- `[email protected]` removed built-in prop types. (facebook@3e229f2)
- `[email protected]` restored built-in prop types, along with bug fixes to isolate deprecated usage. (facebook@b966d29)

We believe that by the next public release, enough time will have passed for the community to be able to upgrade without patching React Native or otherwise working around the removal of these deprecated prop types.

**If anyone has trouble identifying the source of a deleted prop types usage, please file an issue so we can help track it down with you.**

Changelog:
[General][Removed] - Removed deprecated prop types

Reviewed By: lunaleaps, NickGerleman

Differential Revision: D52337762

fbshipit-source-id: 9731f7e1dec29f3df535ab75cc50bed001fdfa0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants