Use conditional type to flattern RN styles #41931
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52142082 |
Summary: `GenericStyleProp` is defined as ``` type GenericStyleProp<+T> = | null | void | T | false | '' | $ReadOnlyArray<GenericStyleProp<T>>; ``` and `____FlattenStyleProp_Internal` is designed to reverse it. We can use conditional type to achieve it instead of $Call: `null | void | false | ''` doesn't contribute to anything doing reversal, so they are mapped to empty. When we encounter $ReadOnlyArray, we recursively apply `____FlattenStyleProp_Internal`. Otherwise, we return the input type. Changelog: [Internal] Reviewed By: jbrown215 Differential Revision: D52142082
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52142082 |
Contributor
|
This pull request has been merged in ce69213. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41931 `GenericStyleProp` is defined as ``` type GenericStyleProp<+T> = | null | void | T | false | '' | $ReadOnlyArray<GenericStyleProp<T>>; ``` and `____FlattenStyleProp_Internal` is designed to reverse it. We can use conditional type to achieve it instead of $Call: `null | void | false | ''` doesn't contribute to anything doing reversal, so they are mapped to empty. When we encounter $ReadOnlyArray, we recursively apply `____FlattenStyleProp_Internal`. Otherwise, we return the input type. Changelog: [Internal] Reviewed By: jbrown215 Differential Revision: D52142082 fbshipit-source-id: 590c71c6400498730675e20c67b173c3bc285d00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
GenericStylePropis defined asand
____FlattenStyleProp_Internalis designed to reverse it. We can use conditional type to achieve it instead of $Call:null | void | false | ''doesn't contribute to anything doing reversal, so they are mapped to empty. When we encounter $ReadOnlyArray, we recursively apply____FlattenStyleProp_Internal. Otherwise, we return the input type.Changelog: [Internal]
Differential Revision: D52142082