Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add isChildPublicInstance to ReactNativeTypes (#27788) #41807

Closed
wants to merge 2 commits into from
Closed

fix: add isChildPublicInstance to ReactNativeTypes (#27788) #41807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e5bfce
Flow: make more objects exact (#27790)
kassens Dec 5, 2023
2f7cc0f
fix: add isChildPublicInstance to ReactNativeTypes (#27788)
hoxyq Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/react-native/Libraries/Renderer/shims/ReactNativeTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noformat
* @flow strict
* @nolint
* @generated SignedSource<<1836a1b6639552dce12199ef2c85f63d>>
* @generated SignedSource<<30640e7dd83e22e14db1648ca63f4316>>
*/

import type {ElementRef, ElementType, Element, AbstractComponent} from 'react';
Expand Down Expand Up @@ -193,6 +193,10 @@ export type ReactNativeType = {
findNodeHandle<TElementType: ElementType>(
componentOrHandle: ?(ElementRef<TElementType> | number),
): ?number,
isChildPublicInstance(
parent: PublicInstance | HostComponent<mixed>,
child: PublicInstance | HostComponent<mixed>,
): boolean,
dispatchCommand(
handle: ElementRef<HostComponent<mixed>>,
command: string,
Expand Down Expand Up @@ -231,6 +235,7 @@ export type ReactFabricType = {
command: string,
args: Array<mixed>,
): void,
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
sendAccessibilityEvent(
handle: ElementRef<HostComponent<mixed>>,
eventType: string,
Expand Down
4 changes: 1 addition & 3 deletions packages/react-native/Libraries/Renderer/shims/ReactNativeViewConfigRegistry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noformat
* @flow strict-local
* @nolint
* @generated SignedSource<<3cf9b746913da1666cb5bce0ae12d978>>
* @generated SignedSource<<73af5b3fe29d226634ed64bc861634df>>
*/

'use strict';
Expand All @@ -24,13 +24,11 @@ export const customBubblingEventTypes: {
skipBubbling?: ?boolean,
}>,
}>,
...
} = {};
export const customDirectEventTypes: {
[eventName: string]: $ReadOnly<{
registrationName: string,
}>,
...
} = {};

const viewConfigCallbacks = new Map<string, ?() => ViewConfig>();
Expand Down
Loading