feat(iOS) make build-hermes-xcode.sh more extensible for out of tree platforms #41387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: c95b2d9 |
cipolleschi
approved these changes
Nov 9, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 7bcfd02. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…platforms (facebook#41387) Summary: This PR aims to make scripts building hermes locally more extensible for out-of-tree platforms. It will make it easier for forks like visionOS to add additional `elif` statements. As a side benefit this PR fixes Hermes builds for MacOS 😄 (I've checked that it now builds correctly) ## Changelog: [IOS] [ADDED] - make build-hermes-xcode.sh more extensible for out-of-tree platforms Pull Request resolved: facebook#41387 Test Plan: Run the local Hermes build by running `USE_HERMES=1 bundle exec pod install` and check if it runs smoothly. Also, a CI check should be sufficient. Reviewed By: dmytrorykun Differential Revision: D51156307 Pulled By: cipolleschi fbshipit-source-id: 1c65b84b16fc8bd0552037c6ef558543cbe03889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR aims to make scripts building hermes locally more extensible for out-of-tree platforms. It will make it easier for forks like visionOS to add additional
elifstatements.As a side benefit this PR fixes Hermes builds for MacOS 😄 (I've checked that it now builds correctly)
Changelog:
[IOS] [ADDED] - make build-hermes-xcode.sh more extensible for out-of-tree platforms
Test Plan:
Run the local Hermes build by running
USE_HERMES=1 bundle exec pod installand check if it runs smoothly. Also, a CI check should be sufficient.