Clean up const and mutable modifiers in RuntimeScheduler #41028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 17, 2023
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: ba5b029f2fbfea72e6e6c2cb2d6a858d37604b7d
rubennorte
force-pushed
the
export-D50364626
branch
from
c75a7c7 to
d296b80
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 17, 2023
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: c0ce5e2e25fd519cde0c7187ec928c36ceb2eef2
rubennorte
force-pushed
the
export-D50364626
branch
from
d296b80 to
ddda5b0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 17, 2023
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: f8e3a10bc685c1f357a8719ac8f530d72435cec4
rubennorte
force-pushed
the
export-D50364626
branch
from
ddda5b0 to
69cf8ea
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 17, 2023
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: d8d6de4a8c611f5aa2bf3677e944acc6100e27b7
rubennorte
force-pushed
the
export-D50364626
branch
from
69cf8ea to
311fc75
Compare
Base commit: c9d0a00 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 17, 2023
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: e1e69b8b0de750d5aeb35bf5ee368fcd06e4e1bc
rubennorte
force-pushed
the
export-D50364626
branch
from
311fc75 to
726be0a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 18, 2023
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: 3b3a25d22e83b82c35f72e4831e5bd8ceb0cfdac
rubennorte
force-pushed
the
export-D50364626
branch
from
726be0a to
d7980d5
Compare
Differential Revision: D49536251 fbshipit-source-id: 008ce27cb43e08cc72cea9e9f28bb388ac93f1ba
Differential Revision: D49316880 fbshipit-source-id: 891989bb7fa4dd363dbcce70426a381b112b160e
Differential Revision: D49316881 fbshipit-source-id: e6ce674184ad3c9a7f205effda43f43e416a6fd5
Differential Revision: D50171297 fbshipit-source-id: 0ca846cac9454c4888d0d390a994aaf8097fe8ca
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: 3570f80acd24c375a9d79209261f5cce816fe674
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50364626 |
rubennorte
force-pushed
the
export-D50364626
branch
from
d7980d5 to
3b0d37a
Compare
Contributor
|
This pull request has been merged in 87dbe44. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
) Summary: Pull Request resolved: facebook#41028 This removes misleading `const` modifiers from some methods in `RuntimeScheduler` that shouldn't really use it, and removes the `mutable` modifiers that were only necessary because of that. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50364626 fbshipit-source-id: 28ed9fa923f8e787166f702ccaecd41a635d3b3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This removes misleading
constmodifiers from some methods inRuntimeSchedulerthat shouldn't really use it, and removes themutablemodifiers that were only necessary because of that.Changelog: [internal]
Reviewed By: sammy-SC
Differential Revision: D50364626