Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOCAL] Fix broken Android tests for 0.72 #38926

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

cortinico
Copy link
Contributor

Summary:

JVM Tests for 0.72 are failing to compile due to a missing ShadowSoLoader class which exists in main. I'm adding it here.

Changelog:

[INTERNAL] - [LOCAL] Fix broken Android tests for 0.72

Test Plan:

Tests are green locally, so should they be on CI

@cortinico cortinico requested a review from lunaleaps August 10, 2023 16:00
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 10, 2023
@cortinico cortinico requested review from Titozzz and fortmarek August 10, 2023 16:00
@lunaleaps lunaleaps merged commit 7b55c7d into 0.72-stable Aug 10, 2023
@lunaleaps lunaleaps deleted the nc/fix-tests-for-072 branch August 10, 2023 16:57
Kudo pushed a commit to expo/react-native that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants