Improve docs of onResponderGrant and expose via Pressability #38195
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47225928 |
Base commit: f6c91bf |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jul 5, 2023
…k#38195) Summary: Pull Request resolved: facebook#38195 `onResponderGrant`'s return value drives the `blockNativeResponder` value for the `setIsJSResponder` native callback. On Android this is used to call `requestDisallowInterceptTouchEvent`, which can be used to prevent a scrollview from activating while another responder is active. Changelog: [Improved] Exposed ability to block native responder in Pressability. Differential Revision: D47225928 fbshipit-source-id: 52a88936a1243c63ef93a6aa43fbcb587e6aa873
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47225928 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jul 5, 2023
…k#38195) Summary: Pull Request resolved: facebook#38195 `onResponderGrant`'s return value drives the `blockNativeResponder` value for the `setIsJSResponder` native callback. On Android this is used to call `requestDisallowInterceptTouchEvent`, which can be used to prevent a scrollview from activating while another responder is active. Changelog: [Improved] Exposed ability to block native responder in Pressability. Differential Revision: D47225928 fbshipit-source-id: c94ed3a3bb98b6266052ddc8969a5d22d1385af8
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47225928 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47225928 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jul 6, 2023
…k#38195) Summary: Pull Request resolved: facebook#38195 `onResponderGrant`'s return value drives the `blockNativeResponder` value for the `setIsJSResponder` native callback. On Android this is used to call `requestDisallowInterceptTouchEvent`, which can be used to prevent a scrollview from activating while another responder is active. Changelog: [Improved] Exposed ability to block native responder in Pressability. Differential Revision: D47225928 fbshipit-source-id: 27dbcadebcd08461ca974d4e4414cd2be41e399e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47225928 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jul 6, 2023
…k#38195) Summary: Pull Request resolved: facebook#38195 `onResponderGrant`'s return value drives the `blockNativeResponder` value for the `setIsJSResponder` native callback. On Android this is used to call `requestDisallowInterceptTouchEvent`, which can be used to prevent a scrollview from activating while another responder is active. Changelog: [Improved] Exposed ability to block native responder in Pressability. Differential Revision: D47225928 fbshipit-source-id: bc695b9f2c25b5fc9aa5b3fe30c74c129e072c98
javache
added a commit
to javache/react-native
that referenced
this pull request
Jul 6, 2023
…k#38195) Summary: Pull Request resolved: facebook#38195 `onResponderGrant`'s return value drives the `blockNativeResponder` value for the `setIsJSResponder` native callback. On Android this is used to call `requestDisallowInterceptTouchEvent`, which can be used to prevent a scrollview from activating while another responder is active. Changelog: [Improved] Exposed ability to block native responder in Pressability. Differential Revision: D47225928 fbshipit-source-id: a436af0eb4dff0b430a49ff94ba7c76948f4d00f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47225928 |
…k#38195) Summary: Pull Request resolved: facebook#38195 `onResponderGrant`'s return value drives the `blockNativeResponder` value for the `setIsJSResponder` native callback. On Android this is used to call `requestDisallowInterceptTouchEvent`, which can be used to prevent a scrollview from activating while another responder is active. Changelog: [Improved] Exposed ability to block native responder in Pressability. Pressables using `cancelable={false}` will now prevent scrolling and other native gestures from activating. Reviewed By: yungsters Differential Revision: D47225928 fbshipit-source-id: 2af222bcf2debc61c42f55e076f3bff18a975eb3
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47225928 |
Contributor
|
This pull request has been merged in 0f393a5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
onResponderGrant's return value drives theblockNativeRespondervalue for thesetIsJSRespondernative callback. On Android this is used to callrequestDisallowInterceptTouchEvent, which can be used to prevent a scrollview from activating while another responder is active.Changelog: [Improved] Exposed ability to block native responder in Pressability. Pressables using
cancelable={false}will now prevent scrolling and other native gestures from activating.Differential Revision: D47225928