Create dev-middleware package #38194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46283818 |
Base commit: e075a3f |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 5, 2023
Summary: Pull Request resolved: facebook#38194 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes Inits the `react-native/dev-middleware` package. Contains an initial implementation of `/open-debugger`, migrated from react-native-community/cli@2535dbe. ## Attribution This implementation is greatly inspired by `expo/dev-server`: https://github.com/expo/expo/blob/1120c716f35cb28d88800e8f5d963d2b2ac94705/packages/%40expo/dev-server/src/JsInspector.ts#L18 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D46283818 fbshipit-source-id: 84cd5a958e32d7c20fd3aef56eaa01547e4ae192
|
This pull request was exported from Phabricator. Differential Revision: D46283818 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 5, 2023
Summary: Pull Request resolved: facebook#38194 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes Inits the `react-native/dev-middleware` package. Contains an initial implementation of `/open-debugger`, migrated from react-native-community/cli@2535dbe. ## Attribution This implementation is greatly inspired by `expo/dev-server`: https://github.com/expo/expo/blob/1120c716f35cb28d88800e8f5d963d2b2ac94705/packages/%40expo/dev-server/src/JsInspector.ts#L18 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D46283818 fbshipit-source-id: 5a6c27082387b5c3ffc0962ebecc6f57ed24b9ed
|
This pull request was exported from Phabricator. Differential Revision: D46283818 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 5, 2023
Summary: Pull Request resolved: facebook#38194 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes Inits the `react-native/dev-middleware` package. Contains an initial implementation of `/open-debugger`, migrated from react-native-community/cli@2535dbe. ## Attribution This implementation is greatly inspired by `expo/dev-server`: https://github.com/expo/expo/blob/1120c716f35cb28d88800e8f5d963d2b2ac94705/packages/%40expo/dev-server/src/JsInspector.ts#L18 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D46283818 fbshipit-source-id: 4eb8e3e09d0ce05418c98526d5d136e6aad0143e
|
This pull request was exported from Phabricator. Differential Revision: D46283818 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D46283818 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 7, 2023
Summary: Pull Request resolved: facebook#38194 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes Inits the `react-native/dev-middleware` package. Contains an initial implementation of `/open-debugger`, migrated from react-native-community/cli@2535dbe. ## Attribution This implementation is greatly inspired by `expo/dev-server`: https://github.com/expo/expo/blob/1120c716f35cb28d88800e8f5d963d2b2ac94705/packages/%40expo/dev-server/src/JsInspector.ts#L18 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D46283818 fbshipit-source-id: c113a773e5f28cfa1723db5a9c51ea4f47fa91bb
Summary: Pull Request resolved: facebook#38194 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes Inits the `react-native/dev-middleware` package. Contains an initial implementation of `/open-debugger`, migrated from react-native-community/cli@2535dbe. ## Attribution This implementation is greatly inspired by `expo/dev-server`: https://github.com/expo/expo/blob/1120c716f35cb28d88800e8f5d963d2b2ac94705/packages/%40expo/dev-server/src/JsInspector.ts#L18 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D46283818 fbshipit-source-id: 298ea6cba663b3946c785e2c2220c809cf554978
|
This pull request was exported from Phabricator. Differential Revision: D46283818 |
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Jul 7, 2023
Summary: X-link: facebook/react-native#38194 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes Inits the `react-native/dev-middleware` package. Contains an initial implementation of `/open-debugger`, migrated from react-native-community/cli@2535dbe. ## Attribution This implementation is greatly inspired by `expo/dev-server`: https://github.com/expo/expo/blob/1120c716f35cb28d88800e8f5d963d2b2ac94705/packages/%40expo/dev-server/src/JsInspector.ts#L18 Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D46283818 fbshipit-source-id: 7b38ad2f6d7346366a7c599d16e289e04b7bd88d
|
This pull request was successfully merged by @huntie in a991ff3. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in a991ff3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
Changes
Inits the
@react-native/dev-middlewarepackage. Contains an initial implementation of/open-debugger, migrated from react-native-community/cli@2535dbe.Motivation + Design
@react-native/dev-middlewareis a focused new package to support new HTTP endpoints on React Native dev servers (e.g. RN CLI), initially to implement two planned new endpoints to support debugging actions in the Dev Menu for the One-click Hermes debugger flow.Logically, this package can be seen as a subset of
@react-native-community/cli-server-api— which we are gradually reintegrating into thereact-nativerepo. It implements debugging actions in the Dev Menu, and interfaces asconnectmiddleware, which is plugged in to Metro's server under the hood.Notes
buildstep (targeting Node.js).chrome-launcheronly.Attribution
This implementation is greatly inspired by
@expo/dev-server: https://github.com/expo/expo/blob/1120c716f35cb28d88800e8f5d963d2b2ac94705/packages/%40expo/dev-server/src/JsInspector.ts#L18Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46283818