Skip to content

Make bounds and resizeMode of gif network images respond to styles #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brentvatne wants to merge 4 commits into from
Closed

Make bounds and resizeMode of gif network images respond to styles #353

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79e1695
Make bounds and scale of gif network images respond to device and styles
Mar 27, 2015
8334fc6
Remove unnecessary line
Mar 27, 2015
d7952ed
Remove static gravity property on gif images
Mar 27, 2015
824ba3e
Fix the content scale at 1.0 because no support for @2x or @3x gifs yet
Mar 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Libraries/Image/RCTNetworkImageView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,8 @@ - (void)setImageURL:(NSURL *)imageURL resetToDefaultImageWhileLoading:(BOOL)rese
_downloadToken = [_imageDownloader downloadDataForURL:imageURL block:^(NSData *data, NSError *error) {
if (data) {
CAKeyframeAnimation *animation = RCTGIFImageWithData(data);
CGImageRef firstFrame = (__bridge CGImageRef)animation.values.firstObject;
self.layer.bounds = CGRectMake(0, 0, CGImageGetWidth(firstFrame), CGImageGetHeight(firstFrame));
self.layer.contentsScale = 1.0;
self.layer.bounds = CGRectMake(0, 0, self.bounds.size.width, self.bounds.size.height);
Copy link
Contributor

@a2 a2 Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is unnecessary.

Copy link
Collaborator Author

@brentvatne brentvatne Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, removed

self.layer.contentsScale = RCTScreenScale();
Copy link
Contributor

@a2 a2 Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is unnecessary but I may be wrong.

Copy link
Collaborator Author

@brentvatne brentvatne Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove it then the image does not show up at all, so it seems necessary

Copy link
Contributor

@a2 a2 Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically we don't currently support @2x or @3x GIFs so maybe change the contentsScale to 1.0? Or, if you want to keep RCTScreenScale(), we need to add that support, maybe by checking the filename suffix before the extension.

Copy link
Collaborator Author

@brentvatne brentvatne Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a2 - good point, let's just make this 1.0 and we can open a separate issue for @2x+ support if you like

self.layer.contentsGravity = kCAGravityResizeAspect;
Copy link
Contributor

@a2 a2 Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to change the contentsGravity if you want full resize control.

Copy link
Collaborator Author

@brentvatne brentvatne Mar 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point again, I suppose we can just remove this line entirely too

self.layer.minificationFilter = kCAFilterLinear;
self.layer.magnificationFilter = kCAFilterLinear;
Expand Down