Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily query for git branch & remote #33936

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

cortinico
Copy link
Contributor

Summary

On RN 0.69, we added a check for current branch/remote/tag.
As they execute eagerly, users which are not inside a git repo will experience a failure. This is addressing it.

Changelog

[Internal] - Lazily query for git branch & remote

Test Plan

I've tested those changes on a newly created project with RC4 and verified that they work correctly.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 31, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,794,286 +6,042
android hermes armeabi-v7a 7,196,479 +4,654
android hermes x86 8,104,137 +4,539
android hermes x86_64 8,083,503 +6,400
android jsc arm64-v8a 9,667,311 +11,006
android jsc armeabi-v7a 8,438,568 +9,759
android jsc x86 9,617,579 +9,101
android jsc x86_64 10,214,421 +11,394

Base commit: f4123b0
Branch: main

Copy link
Contributor

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this locally and can confirm that pod install with the changes here works even without a local git repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants