feat: Add dismissActionSheet method to ActionSheetIOS #33189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
Platform: iOS
Base commit: a7a781f |
Base commit: a7a781f |
|
@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @motiz88, would you mind checking why tests are failing internally? |
| @@ -28,6 +28,7 @@ @implementation RCTActionSheetManager | |||
| RCT_EXPORT_MODULE() | |||
|
|
|||
| @synthesize viewRegistry_DEPRECATED = _viewRegistry_DEPRECATED; | |||
| NSMutableArray<UIAlertController *> *_alertControllers = [NSMutableArray array]; | |||
There was a problem hiding this comment.
Why is _alertControllers added as a global variable?
There was a problem hiding this comment.
Hi @danilobuerger, I've just changed it to be a property instead
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lunaleaps
requested changes
Mar 10, 2022
| @@ -47,6 +47,7 @@ export interface Spec extends TurboModule { | |||
| |}) => void, | |||
| successCallback: (completed: boolean, activityType: ?string) => void, | |||
| ) => void; | |||
| +dismissActionSheet: () => void; | |||
There was a problem hiding this comment.
Can we make this a nullable function? This will break codebases that leverage OTA type safety in the case where this JS is running on a native app where this property isn't defined.
There was a problem hiding this comment.
Sure, I've just updated it
gabrieldonadel
force-pushed
the
feat/add-dismiss-action-sheet
branch
from
7b68548
to
4123f36
Compare
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in 64ebe5b. When will my fix make it into a release? | Upcoming Releases |
cortinico
pushed a commit
to cortinico/react-native
that referenced
this pull request
Mar 12, 2022
Summary: This PR adds a `dismissActionSheet` method to `ActionSheetIOS` in order to allow dismissing an ActionSheet programmatically. This is especially useful in apps where a user has the ability to open an ActionSheet and then open a push notification that will redirect them to another screen which usually leads to scenarios where the presented ActionSheet has no relation with the current screen. #### TODO - [ ] Submit react-native-website PR updating ActionSheetIOS documentation. ## Changelog [iOS] [Added] - Add dismissActionSheet method to ActionSheetIOS Pull Request resolved: facebook#33189 Test Plan: 1. Open the RNTester app and navigate to the ActionSheetIOS page 2. Test `dismissActionSheet` through the `Show Action Sheet and automatically dismiss it` example https://user-images.githubusercontent.com/11707729/155867546-c6770a49-9b09-45e3-a6b1-4f7645d67dbf.mov Reviewed By: lunaleaps Differential Revision: D34518952 Pulled By: cortinico fbshipit-source-id: 912a9b83ee078f791b42efddf5abb7e1cd09d520
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: This PR adds a `dismissActionSheet` method to `ActionSheetIOS` in order to allow dismissing an ActionSheet programmatically. This is especially useful in apps where a user has the ability to open an ActionSheet and then open a push notification that will redirect them to another screen which usually leads to scenarios where the presented ActionSheet has no relation with the current screen. - [ ] Submit react-native-website PR updating ActionSheetIOS documentation. [iOS] [Added] - Add dismissActionSheet method to ActionSheetIOS Pull Request resolved: facebook#33189 Test Plan: 1. Open the RNTester app and navigate to the ActionSheetIOS page 2. Test `dismissActionSheet` through the `Show Action Sheet and automatically dismiss it` example https://user-images.githubusercontent.com/11707729/155867546-c6770a49-9b09-45e3-a6b1-4f7645d67dbf.mov Reviewed By: lunaleaps Differential Revision: D34518952 Pulled By: cortinico fbshipit-source-id: 912a9b83ee078f791b42efddf5abb7e1cd09d520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
dismissActionSheetmethod toActionSheetIOSin order to allow dismissing an ActionSheet programmatically. This is especially useful in apps where a user has the ability to open an ActionSheet and then open a push notification that will redirect them to another screen which usually leads to scenarios where the presented ActionSheet has no relation with the current screen.TODO
Changelog
[iOS] [Added] - Add dismissActionSheet method to ActionSheetIOS
Test Plan
dismissActionSheetthrough theShow Action Sheet and automatically dismiss itexampleScreen.Recording.2022-02-27.at.00.54.10.mov