-
Notifications
You must be signed in to change notification settings - Fork 25k
chore(deps): Bump shelljs from 0.8.4 to 0.8.5 #33001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Base commit: 3f49e67 |
Base commit: 3f49e67 |
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@lunaleaps do you mind checking if fb internal tests are failing due to this change or if it was just a fluke? |
|
Yea we have an internal mirror of dependencies I need to update -- will be updating internally! Thanks again for your help here! |
|
This pull request was successfully merged by @gabrieldonadel in e8f7a1b. When will my fix make it into a release? | Upcoming Releases |
Summary: Running `yarn audit` shows a vulnerability in the `shelljs` version we're currently using  This PR upgrades `shelljs` from 0.8.4 to 0.8.5 in order to mitigate this vulnerability More info on GHSA-4rq4-32rv-6wp6 ## Changelog [Internal] [Security] - Upgrade shelljs to v0.8.5 in order to fix Improper Privilege Management vulnerability Pull Request resolved: facebook#33001 Test Plan: There are no API changes between versions 0.8.4 and 0.8.5, so just testing the scripts that use this lib should be enough. Reviewed By: cortinico Differential Revision: D33897436 Pulled By: lunaleaps fbshipit-source-id: f32b118ff47c6135845ac4de425feb8ebea220a8
Summary
Running
yarn auditshows a vulnerability in theshelljsversion we're currently usingThis PR upgrades
shelljsfrom 0.8.4 to 0.8.5 in order to mitigate this vulnerabilityMore info on GHSA-4rq4-32rv-6wp6
Changelog
[Internal] [Security] - Upgrade shelljs to v0.8.5 in order to fix Improper Privilege Management vulnerability
Test Plan
There are no API changes between versions 0.8.4 and 0.8.5, so just testing the scripts that use this lib should be enough.