Complete missing Flow declarations in URL

[mischnic]

Summary

When transpiling flow with a Babel config like

{
	plugins:  [['@babel/plugin-transform-flow-strip-types', {requireDirective: true}]]
}

all files containing Flow syntax need to have @flow at the top of the file.

node_modules/react-native/Libraries/Blob/URL.js: A @flow directive is required when using Flow annotations with the `requireDirective` option.
  55 |   _searchParams = [];
  56 |
> 57 |   constructor(params: any) {
     |                     ^^^^^
  58 |     if (typeof params === 'object') {
  59 |       Object.keys(params).forEach(key => this.append(key, params[key]));
  60 |     }

In URL, it was removed (mistakenly I think) by 6303850#diff-552f9731d5c9bc329105a5f4224319966395e59b5bb23202b756c5d152e0f007. Only the `strict-local´ part should have been removed, not the whole line.

Changelog

[General] [Fixed] - Complete missing Flow declarations in URL

Test Plan

See above

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 36bbd8f
Branch: main

[lunaleaps]

@mischnic It looks like this was also called out in the original PR: https://github.com/facebook/react-native/pull/22901/files#r246114640 but I guess if flow passes here then it's not an issue?

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,477,542	-195
android	hermes	armeabi-v7a	7,774,787	-202
android	hermes	x86	8,946,689	-191
android	hermes	x86_64	8,893,604	-199
android	jsc	arm64-v8a	9,791,694	-88
android	jsc	armeabi-v7a	8,752,420	-81
android	jsc	x86	9,740,517	-80
android	jsc	x86_64	10,341,386	-82

Base commit: 36bbd8f
Branch: main

[mischnic]

then it's not an issue?

Flow declarations without @flow are essentially dead code (and you can run into problems with other tools such as Babel or flow-remove-types).

Up until now I didn't actually test if Flow passed with my changes, so now I've:

• removed the two "stray" type declarations in WebSocketInterceptor (that were ignored by Flow anyway and missing generic type parameters, now it contains no Flow declarations at all), because there are many missing types in that file
• added all missing types in URL, so Flow passes now

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[lunaleaps]

Why was @flow removed from your last commit?

[lunaleaps]

Could we leave this file untouched -- I realize the types could be dead but I'd prefer we do this in a separate PR so the intent is clearer

[mischnic]

a separate PR

Done #32570

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@lunaleaps merged this pull request in 98abf1b.