feat: add `isAccessibilityServiceEnabled` #31396

grgr-dkrk · 2021-04-21T13:31:13Z

Summary

fix #30863

This PR adds isAccessibilityServiceEnabled to get if accessibility services are enabled on Android.

Changelog

[Android] [Added] - Added isAccessibilityServiceEnabled to get if accessibility services are enabled

Test Plan

…NAME

analysis-bot

Code analysis results:

google-java-format found some issues. See https://github.com/google/google-java-format

analysis-bot · 2021-04-21T13:40:48Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

@@ -46,6 +46,17 @@ public void onTouchExplorationStateChanged(boolean enabled) {
    }
  }

+  // Android can listen for accessibility service enable with `accessibilityStateChange`, but `accessibilityState` conflicts with React Native props and confuses developers. Therefore, the name `accessibilityServiceChange` is used here instead.


google-java-format suggested changes:

@@ -49 +49,3 @@ - // Android can listen for accessibility service enable with `accessibilityStateChange`, but `accessibilityState` conflicts with React Native props and confuses developers. Therefore, the name `accessibilityServiceChange` is used here instead. + // Android can listen for accessibility service enable with `accessibilityStateChange`, but + // `accessibilityState` conflicts with React Native props and confuses developers. Therefore, the + // name `accessibilityServiceChange` is used here instead.

analysis-bot · 2021-04-21T13:40:48Z

...roid/src/main/java/com/facebook/react/modules/accessibilityinfo/AccessibilityInfoModule.java

+      }
+    }
+  }
+
  @Override
  @TargetApi(Build.VERSION_CODES.LOLLIPOP)


google-java-format suggested changes:

@@ -176,2 +178 @@ - mAccessibilityManager.addAccessibilityStateChangeListener( - mAccessibilityServiceChangeListener); + mAccessibilityManager.addAccessibilityStateChangeListener(mAccessibilityServiceChangeListener);

analysis-bot · 2021-04-21T13:57:14Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 61e1b6f
Branch: main

amarlette · 2021-04-22T22:40:43Z

Thank you for submitting this @grgr-dkrk! I've added your PR to the Improved React Native Accessibility board. Thank you for your contribution to a more accessible React Native.

kacieb · 2021-04-23T19:33:11Z

Libraries/Components/AccessibilityInfo/AccessibilityInfo.js

@@ -33,6 +33,7 @@ type AccessibilityEventDefinitions = {
  change: [boolean], // screenReaderChanged
  reduceMotionChanged: [boolean],
  screenReaderChanged: [boolean],
+  accessibilityServiceChanged: [boolean],


If this event is only supported on Android, we should mark that (perhaps by adding a new type AccessibilityEventDefinitionsAndroid like iOS has.

kacieb · 2021-04-23T19:33:47Z

This is interesting - so this listens for any change? cc @blavalla I know we discussed this a bit, would the potential use case for this be to listen for changes so as to be able to update the layout (or similar) if, for example, TalkBack was turned on/off? So you'd need to listen for changes, and then check if TalkBack is on with another function call.

blavalla · 2021-04-24T00:14:52Z

This is interesting - so this listens for any change? cc @blavalla I know we discussed this a bit, would the potential use case for this be to listen for changes so as to be able to update the layout (or similar) if, for example, TalkBack was turned on/off? So you'd need to listen for changes, and then check if TalkBack is on with another function call.

Yeah, thats the general idea. Although we already have a method specifically for talkback with screenReaderChanged. This would be able to detect any service changing, since on Android there can be 3rd party accessibility services, the API google provides doesn't have methods for specific services (talkback, switch access, etc.) like iOS does.

pull-bot · 2021-10-19T13:34:47Z

PR build artifact for ccc99be is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

analysis-bot · 2021-10-19T13:56:39Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,311,451	+21,438
android	hermes	armeabi-v7a	7,875,632	+21,571
android	hermes	x86	8,678,642	+21,603
android	hermes	x86_64	8,637,847	+21,710
android	jsc	arm64-v8a	9,813,274	+21,909
android	jsc	armeabi-v7a	8,774,264	+22,039
android	jsc	x86	9,762,315	+22,077
android	jsc	x86_64	10,363,241	+22,173

Base commit: 61e1b6f
Branch: main

pull-bot · 2021-10-22T01:35:31Z

PR build artifact for 1e641c1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

lunaleaps · 2021-10-25T22:44:47Z

@grgr-dkrk Can we update the title since the API is isAccessibilityServiceEnabled instead of isAccessibilityStateEnabled?

And similarly, could you also create some documentation for this API in react-native-website? Thank you!

facebook-github-bot · 2021-10-25T22:45:33Z

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

grgr-dkrk · 2021-10-26T06:55:14Z

@lunaleaps

And similarly, could you also create some documentation for this API in react-native-website?

I'll deal with it as soon as possible. Thanks!

grgr-dkrk · 2021-10-27T13:15:09Z

@lunaleaps
I have sent a PR to the documentation for this feature. Thanks.
facebook/react-native-website#2830

lunaleaps

Some additional clarification requested.

lunaleaps · 2021-10-27T18:37:38Z

Libraries/Components/AccessibilityInfo/AccessibilityInfo.js

+   * Returns a promise which resolves to a boolean.
+   * The result is `true` when any service is enabled and `false` otherwise.
+   *
+   * See https://reactnative.dev/docs/accessibilityinfo.html#isAccessibilityServiceEnabled


Point by @philIip that this comment should also mention that it's an Android only feature

packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js

lunaleaps · 2021-10-27T18:50:32Z

Small comments, I can also add if you're okay with the suggested change, otherwise looks good. Just want to get more experienced Android eyes on this as well internally!

pull-bot · 2021-10-28T14:15:22Z

PR build artifact for ab66bd2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2021-10-28T22:20:18Z

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-10-30T01:41:13Z

@lunaleaps merged this pull request in c8b83d4.

grgr-dkrk added 4 commits April 11, 2021 00:25

feat: add isAccessibilityStateEnabled

5521d78

accessibilityState -> accessibilityService

1537588

change ACCESSIBILITY_STATE_EVENT_NAME to ACCESSIBILITY_SERVICE_EVENT_…

4b4ec0e

…NAME

change type of isAccessibilityServiceEnabled

6fe11f8

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2021

analysis-bot suggested changes Apr 21, 2021

View reviewed changes

fix suggestion

4bb94c8

amarlette added the Accessibility label Apr 22, 2021

amarlette requested a review from kacieb April 22, 2021 22:29

kacieb self-assigned this Apr 23, 2021

kacieb requested a review from blavalla April 23, 2021 19:30

kacieb reviewed Apr 23, 2021

View reviewed changes

fix: suggestion

ac05878

grgr-dkrk requested a review from kacieb May 4, 2021 01:00

react-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Oct 1, 2021

Merge branch 'main' into feat/add_accessibility_state_listener

ccc99be

chore: fix accessibilityExample for flow check

1e641c1

kacieb requested a review from lunaleaps October 25, 2021 15:08

kacieb removed their assignment Oct 25, 2021

lunaleaps added the Needs: React Native Team Attention label Oct 25, 2021

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 25, 2021

leofolive approved these changes Oct 26, 2021

View reviewed changes

grgr-dkrk changed the title ~~feat: add isAccessibilityStateEnabled~~ feat: add isAccessibilityServiceEnabled Oct 26, 2021

grgr-dkrk mentioned this pull request Oct 27, 2021

feat(accessibility): add isAccessibilityServiceEnabled section facebook/react-native-website#2830

Merged

lunaleaps reviewed Oct 27, 2021

View reviewed changes

fix(accessibilityInfo): fix suggestions

ab66bd2

lunaleaps approved these changes Oct 28, 2021

View reviewed changes

facebook-github-bot closed this in c8b83d4 Oct 30, 2021

facebook-github-bot added the Merged This PR has been merged. label Oct 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `isAccessibilityServiceEnabled` #31396

feat: add `isAccessibilityServiceEnabled` #31396

grgr-dkrk commented Apr 21, 2021

analysis-bot left a comment

analysis-bot Apr 21, 2021

analysis-bot Apr 21, 2021

analysis-bot commented Apr 21, 2021 •

edited

Loading

amarlette commented Apr 22, 2021

kacieb Apr 23, 2021

kacieb commented Apr 23, 2021

blavalla commented Apr 24, 2021

pull-bot commented Oct 19, 2021

analysis-bot commented Oct 19, 2021 •

edited

Loading

pull-bot commented Oct 22, 2021

lunaleaps commented Oct 25, 2021 •

edited

Loading

facebook-github-bot commented Oct 25, 2021

grgr-dkrk commented Oct 26, 2021

grgr-dkrk commented Oct 27, 2021

lunaleaps left a comment

lunaleaps Oct 27, 2021

lunaleaps commented Oct 27, 2021

pull-bot commented Oct 28, 2021

facebook-github-bot commented Oct 28, 2021

facebook-github-bot commented Oct 30, 2021

feat: add isAccessibilityServiceEnabled #31396

feat: add isAccessibilityServiceEnabled #31396

Conversation

grgr-dkrk commented Apr 21, 2021

Summary

Changelog

Test Plan

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot Apr 21, 2021

Choose a reason for hiding this comment

analysis-bot Apr 21, 2021

Choose a reason for hiding this comment

analysis-bot commented Apr 21, 2021 • edited Loading

amarlette commented Apr 22, 2021

kacieb Apr 23, 2021

Choose a reason for hiding this comment

kacieb commented Apr 23, 2021

blavalla commented Apr 24, 2021

pull-bot commented Oct 19, 2021

analysis-bot commented Oct 19, 2021 • edited Loading

pull-bot commented Oct 22, 2021

lunaleaps commented Oct 25, 2021 • edited Loading

facebook-github-bot commented Oct 25, 2021

grgr-dkrk commented Oct 26, 2021

grgr-dkrk commented Oct 27, 2021

lunaleaps left a comment

Choose a reason for hiding this comment

lunaleaps Oct 27, 2021

Choose a reason for hiding this comment

lunaleaps commented Oct 27, 2021

pull-bot commented Oct 28, 2021

facebook-github-bot commented Oct 28, 2021

facebook-github-bot commented Oct 30, 2021

feat: add `isAccessibilityServiceEnabled` #31396

feat: add `isAccessibilityServiceEnabled` #31396

analysis-bot commented Apr 21, 2021 •

edited

Loading

analysis-bot commented Oct 19, 2021 •

edited

Loading

lunaleaps commented Oct 25, 2021 •

edited

Loading