Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformColors: add missing clearColor for iOS #30054

Closed
wants to merge 2 commits into from

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Sep 28, 2020

Summary

This small PR adds missing clearColor to the avaiable PlatformColors on iOS.

Please let me know if you would like to see "Fixed colors" added to the PlatformColors. I can address this within this PR or create a separate one.

Changelog

[iOS] [Added] - PlatformColors: add missing clearColor

Test Plan

(I had to disable the Dark Mode to fix the RNTester readability problems)

Transparent/clear color has been added to the RNTester PlatformColors API example:
IMG_6782

@Simek Simek requested a review from shergin as a code owner September 28, 2020 15:36
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 28, 2020
@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Sep 28, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2c896d3

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,371,273 76
android hermes armeabi-v7a 6,998,341 72
android hermes x86 7,811,769 72
android hermes x86_64 7,703,311 68
android jsc arm64-v8a 9,516,326 84
android jsc armeabi-v7a 9,135,538 80
android jsc x86 9,382,406 80
android jsc x86_64 9,963,324 80

Base commit: 2c896d3

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sammy-SC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Simek in b7167c2.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants