Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix StatusBar showHideTransition flow type issue #29034

Closed
wants to merge 1 commit into from

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jun 2, 2020

Summary

This small PR adds third, missing StatusBarAnimation possible value to the showHideTransition prop validation - 'none'.

This fixes the following issue when <StatusBar showHideTransition="none" /> code is used:

Screenshot 2020-06-02 at 22 39 37

Changelog

[iOS] [Fixed] - fix StatusBar showHideTransition flow type issue

Test Plan

I have run the flow check in the test project which uses local working copy of react-native with this change included.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2020
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Jun 2, 2020
@analysis-bot
Copy link

analysis-bot commented Jun 2, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 809568 n/a

Base commit: ceb6c3d

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,763,992 -20
android hermes armeabi-v7a 6,426,224 -5
android hermes x86 7,149,243 -20
android hermes x86_64 7,039,745 -33
android jsc arm64-v8a 8,932,495 3
android jsc armeabi-v7a 8,587,102 -14
android jsc x86 8,760,865 -14
android jsc x86_64 9,337,009 11

Base commit: ceb6c3d

@elicwhite
Copy link
Member

I'm not familiar with this code, can you include more context showing how showHideTransition is related to StatusBarAnimation and that 'none' is a valid type for this prop?

@Simek
Copy link
Collaborator Author

Simek commented Jun 18, 2020

@TheSavior Code based on the website example, which I have used to validate the docs:

@Simek
Copy link
Collaborator Author

Simek commented Jun 18, 2020

UIStatusBarAnimation enum page in Apple docs:

@Simek
Copy link
Collaborator Author

Simek commented Jun 27, 2020

@TheSavior Are you waiting for some more information or what's the issue here?

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Simek in e5a8f42.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants