-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix StatusBar showHideTransition flow type issue #29034
Conversation
Base commit: ceb6c3d |
Base commit: ceb6c3d |
I'm not familiar with this code, can you include more context showing how |
@TheSavior Code based on the website example, which I have used to validate the docs: |
|
@TheSavior Are you waiting for some more information or what's the issue here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @Simek in e5a8f42. When will my fix make it into a release? | Upcoming Releases |
Summary
This small PR adds third, missing
StatusBarAnimation
possible value to theshowHideTransition
prop validation -'none'
.This fixes the following issue when
<StatusBar showHideTransition="none" />
code is used:Changelog
[iOS] [Fixed] - fix StatusBar showHideTransition flow type issue
Test Plan
I have run the
flow
check in the test project which uses local working copy ofreact-native
with this change included.