[Android] Fix TextInput Cursor jumping to the right when the placeholder null

[fabOnReact]

Summary

This issue fixes #28794 fixes #27658
Flow type ?Stringish allows to set the placeholder value to null. The null value causes the cursor to jump to the right in a TextInput. The fix replaces the placeholder null value with an empty string which avoid calling setHint(null) as causes the placeholder to jump to the right.

Changelog

[Android] [Fixed] - avoid calling setHint with a null parameter causing cursor to jump to the right

Test Plan

CLICK TO OPEN TESTS RESULTS (28 May 2020 20a9473)

More videos and information included in issue #28794
The below test cases are from the following repository

BEFORE

AFTER

Extensive testing on RNTester did not identify any regression.

AFTER

CLICK TO OPEN TESTS RESULTS (15 February 2021 20a9473)

BEFORE
2021-02-15.15-48-54.mp4

AFTER
2021-02-15.15-44-55.mp4

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,891,047	-5,897
android	hermes	armeabi-v7a	8,394,773	+5,429
android	hermes	x86	9,380,311	-5,140
android	hermes	x86_64	9,323,030	-5,111
android	jsc	arm64-v8a	10,341,051	-289,994
android	jsc	armeabi-v7a	9,827,876	-278,630
android	jsc	x86	10,391,813	-289,236
android	jsc	x86_64	10,974,791	-289,203

Base commit: 7b09eb5

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 7b09eb5

[ShivamJoker]

I have tested this code and it works perfect please merge it

[devinjameson]

Why has this not been merged yet?

[safaiyeh]

cc @JoshuaGross

[Elijen]

@hramos @rickhanlonii 🙏

[fabOnReact]

@Haris-Shahid i'll test again, but it worked when I wrote this pr...

[Yandamuri]

when will this be merged?

[sosunny]

@Haris-Shahid i'll test again, but it worked when I wrote this pr...

Did you test it works by any chance? It didn't fix the issue for me either with RN v0.63.4 :/

[sreuter]

@fabriziobertoglio1987 I've noticed you just updated this PR recently. Any chance of this getting merged soon. This also just seems to happen when textAlign is set to center, correct?

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@lunaleaps merged this pull request in 3560753.

[ShivamJoker]

Wow finally after 2 years, folks at facebook merged this PR 😳🤦

[alichampion]

In which version of react-native it will work fine?

[lunaleaps]

In which version of react-native it will work fine?

https://github.com/facebook/react-native/wiki/Release-FAQ#when-will-my-fix-make-it-into-a-release