Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packager][windows] fixing packager module resolving #2829

Closed
wants to merge 1 commit into from

Conversation

mqli
Copy link
Contributor

@mqli mqli commented Sep 18, 2015

By using module path as module id cause issues when generate bundle code.
Such as

__d('reactnativedemo\index.android.js',["react-native\\Libraries\\react-native\\react-native.js"],function(global, require, module, exports) {  'use strict';

__d('react-native\Libraries\react-native\react-native.js',[],function(global, require, module, exports) {  'use strict';

Replace the Win path '' or '' in module name and dependence to '/' before generating bundle code,it make sure the bundle get the same module id,and will get the same bundle code form different OS.

By using module path as module id cause issues when resolving module dependence,change Win path like'\\' or '\' to '/' before generate bundle code.
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 18, 2015
@tdzl2003
Copy link
Contributor

duplicate with #2813

@mkonicek
Copy link
Contributor

Thanks a lot for the fix. #2813 is in now (450cd5c) so closing this one.

@mkonicek mkonicek closed this Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants