-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ACCESS_BACKGROUND_LOCATION to PermissionsAndroid #26562
add ACCESS_BACKGROUND_LOCATION to PermissionsAndroid #26562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also update the NativePermissionsAndroid.js
file? There's a commented out list of permissions, which would be nice to keep in sync with what's here
for this reason I use react-native-permissions - it's up to date more or less, and unifies (as much as possible) the ios vs android permissions request experience, if you haven't seen it... |
Maybe it's worth to deprecate this module in favor of the community one? cc @cpojer |
I think that module is another that is largely single-maintainer and just today released 2.0.0 (meaning: will likely need some more effort short-term) so it might be nice to offer help at the same time, but I do like that module and found it more complete than the built-in APIs, $0.02) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @dulmandakh in 8c099b5. When will my fix make it into a release? | Upcoming Releases |
…ION (#26668) Summary: #26562 added support for ACCESS_BACKGROUND_LOCATION permission, and thymikee requested to update NativePermissionsAndroid.js too. This PR updates NativePermissionsAndroid.js to include ACCESS_BACKGROUND_LOCATION ## Changelog [Android] [Changed] - update NativePermissionsAndroid.js to include ACCESS_BACKGROUND_LOCATION Pull Request resolved: #26668 Test Plan: Everything builds and runs as expected Differential Revision: D17683670 Pulled By: cpojer fbshipit-source-id: 5fe342e79a0d29ba69dddfe70f0fa950498abd50
Summary
This PR adds ACCESS_BACKGROUND_LOCATION to PermissionsAndroid. Fixes #26541
Changelog
[Android] [Changed] - add ACCESS_BACKGROUND_LOCATION to PermissionsAndroid
Test Plan