Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ACCESS_BACKGROUND_LOCATION to PermissionsAndroid #26562

Closed

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Sep 25, 2019

Summary

This PR adds ACCESS_BACKGROUND_LOCATION to PermissionsAndroid. Fixes #26541

Changelog

[Android] [Changed] - add ACCESS_BACKGROUND_LOCATION to PermissionsAndroid

Test Plan

PermissionsAndroid.ACCESS_BACKGROUND_LOCATION === 'android.permission.ACCESS_BACKGROUND_LOCATION'

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 25, 2019
Copy link
Contributor

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the NativePermissionsAndroid.js file? There's a commented out list of permissions, which would be nice to keep in sync with what's here

@mikehardy
Copy link
Contributor

for this reason I use react-native-permissions - it's up to date more or less, and unifies (as much as possible) the ios vs android permissions request experience, if you haven't seen it...

@thymikee
Copy link
Contributor

Maybe it's worth to deprecate this module in favor of the community one? cc @cpojer

@mikehardy
Copy link
Contributor

I think that module is another that is largely single-maintainer and just today released 2.0.0 (meaning: will likely need some more effort short-term) so it might be nice to offer help at the same time, but I do like that module and found it more complete than the built-in APIs, $0.02)

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dulmandakh in 8c099b5.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 30, 2019
facebook-github-bot pushed a commit that referenced this pull request Oct 11, 2019
…ION (#26668)

Summary:
#26562 added support for ACCESS_BACKGROUND_LOCATION permission, and thymikee requested to update NativePermissionsAndroid.js too. This PR updates NativePermissionsAndroid.js to include ACCESS_BACKGROUND_LOCATION

## Changelog

[Android] [Changed] - update NativePermissionsAndroid.js to include ACCESS_BACKGROUND_LOCATION
Pull Request resolved: #26668

Test Plan: Everything builds and runs as expected

Differential Revision: D17683670

Pulled By: cpojer

fbshipit-source-id: 5fe342e79a0d29ba69dddfe70f0fa950498abd50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: PermissionsAndroid CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Feature request) ACCESS_BACKGROUND_LOCATION in PermissionsAndroid
6 participants