Allow jest globals in __mocks__ directories #25738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `__mocks__` directories should be treated the same as `__tests__` for the purpose of linting. See https://jestjs.io/docs/en/manual-mocks
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Jul 19, 2019
facebook-github-bot
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
@osdnk is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks! |
osdnk
approved these changes
Jul 26, 2019
|
This pull request was successfully merged by @artdent in e78c013. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
__mocks__directories should be treated the same as__tests__for the purpose of linting. See https://jestjs.io/docs/en/manual-mocks
Changelog
[Internal] [Changed] - eslint: allow jest globals in
__mocks__directoriesTest Plan
I installed the updated package locally in my project and verified
that the
no-undefrule no longer fires for references tojestin__mocks__directories.