-
Notifications
You must be signed in to change notification settings - Fork 25k
[Text] Ensure that the text background is transparent by default #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0239b40 to
8b8e691
Compare
eafb8c8 to
a7315fb
Compare
|
@ide While this waits to be merged, how do you set the background to transparent at the moment? |
|
@josebalius - just |
|
@brentvatne For some reason that doesn't seem to work for me :/ It works on almost everything but |
|
@josebalius - strange, can you paste the code here? |
|
Sure Stylesheet: Component's render: styles.create / styles.account are the ones not working, the other two with transparent properties are fine. |
|
@amasad Nvm I had |
For a very simple view I was observing that the text background was black and had to manually be set to transparent. This ensures that text nodes have a transparent background by default.
Test Plan: This example component no longer renders what looks like a black block, and instead displays legible text.
var Example = React.createClass({
render: function() {
return (
<View style={styles.container}>
<Text>hello</Text>
</View>
);
},
});
var styles = StyleSheet.create({
container: {
flex: 1,
},
};
a7315fb to
9b6b1a3
Compare
…IScene support from upstream. (facebook#256) * Fix manual merge error. * Fix missing getters from react-native-implementation.macos.js. Cherry pick facebook#28147 into fork to Make RCTKeyWindow multi-window aware and add UIScene support to RCTRedBox. * release _window now to ensure its UIKit ivars are dealloc'd on the main thread as the RCTRedBox can be dealloc'd on a background thread
For a very simple view I was observing that the text background was black and had to manually be set to transparent. This ensures that text nodes have a transparent background by default.
Test Plan: This example component no longer renders what looks like a black block, and instead displays legible text.