Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent reporting native module name on crash on native side #24704

Conversation

DimitryDushkin
Copy link

Summary

PR #24633 introduced some inconsistency in crash messaging, this PR fix it. Asked by @mhorowitz

Changelog

[General] [Added] - Consistent reporting native module name on crash on native side

Test Plan

Actually I didn't managed to reproduce this kind of crash, looks like something changed here.

@DimitryDushkin DimitryDushkin force-pushed the consistent-crash-message-in-jscruntime branch from 4d5ef0c to 8259ede Compare May 3, 2019 17:54
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 3, 2019
@mhorowitz
Copy link
Contributor

Thanks! The code change looks good to me. I think I'm having some issue on my end accepting, so I'll let @cpojer do that.

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label May 3, 2019
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @DimitryDushkin in d6c33f9.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 7, 2019
@cpojer
Copy link
Contributor

cpojer commented May 7, 2019

Unfortunately this broke some stuff at FB and we had to revert it:

Summary: 
react-native/Libraries/Blob/RCTBlobCollector.h:8:9: fatal error: 'jsi/jsi.h' file not found
#import <jsi/jsi.h>
        ^~~~~~~~~~~

Do you mind sending the same PR again with the correct fix? Thank you!

(Not sure why this was able to land in the first place, oops!)

@cpojer
Copy link
Contributor

cpojer commented May 7, 2019

Oh actually nevermind, we had two PRs landing at the same time and the other one was causing this issue. Do you mind sending the same PR again so I can re-land it? Thank you!

@DimitryDushkin
Copy link
Author

Oh actually nevermind, we had two PRs landing at the same time and the other one was causing this issue. Do you mind sending the same PR again so I can re-land it? Thank you!

Sure — #24741

facebook-github-bot pushed a commit that referenced this pull request May 7, 2019
Summary:
_Reopened PR_ #24704 (comment)
PR #24633 introduced some inconsistency in crash messaging, this PR fix it. Asked by mhorowitz

[General] [Added] - Consistent reporting native module name on crash on native side
Pull Request resolved: #24741

Differential Revision: D15242415

Pulled By: cpojer

fbshipit-source-id: 8346ffd7c74070ec676aa006c9791a4729946204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants