-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent reporting native module name on crash on native side #24704
Consistent reporting native module name on crash on native side #24704
Conversation
4d5ef0c
to
8259ede
Compare
Thanks! The code change looks good to me. I think I'm having some issue on my end accepting, so I'll let @cpojer do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @DimitryDushkin in d6c33f9. When will my fix make it into a release? | Upcoming Releases |
Unfortunately this broke some stuff at FB and we had to revert it:
Do you mind sending the same PR again with the correct fix? Thank you! (Not sure why this was able to land in the first place, oops!) |
Oh actually nevermind, we had two PRs landing at the same time and the other one was causing this issue. Do you mind sending the same PR again so I can re-land it? Thank you! |
Sure — #24741 |
Summary: _Reopened PR_ #24704 (comment) PR #24633 introduced some inconsistency in crash messaging, this PR fix it. Asked by mhorowitz [General] [Added] - Consistent reporting native module name on crash on native side Pull Request resolved: #24741 Differential Revision: D15242415 Pulled By: cpojer fbshipit-source-id: 8346ffd7c74070ec676aa006c9791a4729946204
Summary
PR #24633 introduced some inconsistency in crash messaging, this PR fix it. Asked by @mhorowitz
Changelog
[General] [Added] - Consistent reporting native module name on crash on native side
Test Plan
Actually I didn't managed to reproduce this kind of crash, looks like something changed here.