[Travis] Put $PWD in front of nvm (fixes npm install) #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem where NVM_DIR wasn't correctly configured, which meant that `npm install` was using whatever version of Node was on the system (0.12 in this case) despite having run `nvm use iojs-v2`. Fixing up NVM_DIR fixes the `npm install` errors and builds the native npm packages for the right version of Node.
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
cc @vjeux can I just merge this or does it need to be synced? |
|
We're not syncing it, you are all clear |
|
Thanks for figuring it out :) |
vjeux
added a commit
that referenced
this pull request
Aug 21, 2015
[Travis] Put $PWD in front of nvm (fixes npm install)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem where NVM_DIR wasn't correctly configured, which meant that
npm installwas using whatever version of Node was on the system (0.12 in this case) despite having runnvm use iojs-v2. Fixing up NVM_DIR fixes thenpm installerrors and builds the native npm packages for the right version of Node.