Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Add HMRLoadingView module for web target #23389

Closed
wants to merge 2 commits into from
Closed

[Web] Add HMRLoadingView module for web target #23389

wants to merge 2 commits into from

Conversation

EvanBacon
Copy link
Contributor

Summary

  • Added a default value for HMRLoadingView this will prevent errors from being thrown when HMRClient attempts to include it in a web context.

Changelog

  • [Web] [Added] - HMRLoadingView

Test Plan

  • No new features.

@EvanBacon
Create HMRLoadingView.js
9457299 
* Added a default value for HMRLoadingView this will prevent errors from being thrown when `HMRClient` attempts to include it in a `web` context.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2019
analysis-bot
analysis-bot suggested changes Feb 12, 2019
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

Libraries/Utilities/HMRLoadingView.js
@@ -0,0 +1,23 @@
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate module provider for HMRLoadingView. Change either this module provider or the current module provider [1].

@pull-bot
Copy link

pull-bot commented Feb 12, 2019 •
edited
Loading

Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS against e2b7aa3

@EvanBacon
Copy link
Contributor Author

Hold pending #23387

cpojer
cpojer approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default is fine with me, as it is not platform specific and any non Android or iOS platform would run into this if they wanted to use HMR.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 12, 2019
facebook-github-bot
facebook-github-bot approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 13, 2019
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@EvanBacon
Copy link
Contributor Author

@cpojer does this file exist in the internal repo? Outside of that I'm not sure what I would change to make this more compatible (besides the extension ofc).

@cpojer
Copy link
Contributor

cpojer commented Feb 15, 2019

Haven't gotten around to do this again. We actually need to ignore this file in .flowconfig for now. Could you update the two in the root of this repo? That helps me land this faster :)

facebook-github-bot
facebook-github-bot reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 21, 2019
@react-native-bot
Copy link
Collaborator

@EvanBacon merged commit 104b1f9 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 21, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 21, 2019
mbardauskas pushed a commit to mbardauskas/react-native that referenced this pull request Feb 21, 2019
@EvanBacon
Add HMRLoadingView module for web target (facebook#23389)
d6b96ce 
Summary:
* Added a default value for HMRLoadingView this will prevent errors from being thrown when `HMRClient` attempts to include it in a `web` context.

* [Web] [Added] - HMRLoadingView
Pull Request resolved: facebook#23389

Differential Revision: D14045475

Pulled By: cpojer

fbshipit-source-id: df5c3cf3536af3b37eaf82342b6346bc25054319
@hramos hramos added Partner p: Expo Partner: Expo and removed Import Failed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@analysis-bot analysis-bot analysis-bot requested changes

@cpojer cpojer cpojer approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@EvanBacon @pull-bot @facebook-github-bot @cpojer @react-native-bot @analysis-bot @hramos