Fix SwipeableActionButton styling. #23113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Jan 23, 2019
cpojer
approved these changes
Jan 23, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for the PR! You are right, this looks like an unintentional bug that was introduced recently. |
|
@varungupta85 merged commit ad52f52 into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change: Changelog: ---------- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [General] [Fixed] - Same style was applied twice to SwipeableQuickActionButton in a recent commit causing problems with the buttons layout. Pull Request resolved: facebook#23113 Differential Revision: D13781896 Pulled By: cpojer fbshipit-source-id: 659ddaed32b6a1e90080344ea3b0b42088fd9783
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change:
Changelog:
Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example.
[General] [Fixed] - Same style was applied twice to SwipeableQuickActionButton in a recent commit causing problems with the buttons layout.
Test Plan:
I have tested the changes locally in my app. The swipeable action buttons got messed up after I upgraded to latest react native. I found that a recent commit 886d705#diff-46bd7d6f94be9729ed39ea900705327e has added support for a custom view but in the process, we are applying the passed in style twice to the buttons. Also, I don't see the point of applying passed in style to a custom view when a user can just apply it themselves while passing it.
Below is how the quick action buttons appeared after the upgrade. They are supposed to take up equal space.
This is how they appeared after the fix. This is exactly how they appeared before I upgraded react-native also.
To test it, I am using a swipeable flat list where each item is a swipeable row. The swipeable actions are given equal space among each by using a
flex: 1.