-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map textContentType strings to Objective-C constants #22579
Map textContentType strings to Objective-C constants #22579
Conversation
2edf7bc
to
792c06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@levibuzolic merged commit 077386a into |
Ooops, this diff was reverted because of some internal breakage. I will try to understand the exact reason and fix later this week. |
This PR failed with this log:
|
Probably needs some #ifdef around the constants that are not defined in older ios versions. |
Summary: Fixes #22578 Currently the only `textContentType` values that work are: `username`, `password`, `location`, `name` and `nickname`. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue #22578 has more detail examples/explanation. Pull Request resolved: facebook/react-native#22579 Differential Revision: D13402177 Pulled By: shergin fbshipit-source-id: 55f4a2029cd3ea1fb4834e9f56d2df5a05b31b4e
Fixes #22578
Currently the only
textContentType
values that work are:username
,password
,location
,name
andnickname
. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue #22578 has more detail examples/explanation.Test Plan:
Added a Text Content Type example to the RNTester app which shows two examples which weren't previously working.
Changelog:
[iOS] [Fixed] - Fixes textContentTypes not working by mapping textContentType strings to Objective-C constants - Fixes #22578