Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility issue for android 16 device.Fixes #22294 #22295

Closed
wants to merge 1 commit into from
Closed

Fix compatibility issue for android 16 device.Fixes #22294 #22295

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Nov 15, 2018 •
edited
Loading

Motivation

Fix compatibility issue for android 16 device. Related issue #22295.

Test Plan

pass all current ci.

Related PRs

none

Release Notes

[GENERAL] [ANDROID] [Fixed] - Fix compatibility issue for android 16 device

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2018
@gengjiawen gengjiawen mentioned this pull request Nov 15, 2018
Closed
@gengjiawen
Copy link
Contributor Author

@stepanhruda please review.

@gengjiawen gengjiawen changed the title Fix compatibility issue for android 16 device (Fixes #22294) Fix compatibility issue for android 16 device.Fixes #22294 Nov 15, 2018
@gengjiawen gengjiawen added Platform: Android Android applications. ✅Release Notes Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. labels Nov 15, 2018
@gengjiawen gengjiawen mentioned this pull request Nov 15, 2018
Closed
@hramos
Copy link
Contributor

hramos commented Nov 15, 2018

The test_android failure should be unrelated. Can you re-run the test_android workflow to make sure? There's a button at the top right of the window at
https://circleci.com/gh/gengjiawen/react-native/1237?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link that can do that.

@gengjiawen
Copy link
Contributor Author

I will run it again.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Nov 15, 2018
facebook-github-bot
facebook-github-bot approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

hey99xx
hey99xx reviewed Nov 15, 2018
View reviewed changes
ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.java
@@ -7,6 +7,7 @@

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
Copy link

@hey99xx hey99xx Nov 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not deleting this line ( import java.nio.charset.StandardCharsets )? it won't crash but still incorrect to import it, may be accidentaly used again in the future

@react-native-bot
Copy link
Collaborator

@gengjiawen merged commit 5939d07 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Nov 15, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 15, 2018
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@gengjiawen @facebook-github-bot
Fix compatibility issue for android 16 device.Fixes facebook#22294 (f…
bb30456 
…acebook#22295)

Summary:
Fix compatibility issue for android 16 device. Related issue facebook#22295.
pass all current ci.
none
 [GENERAL] [ANDROID] [Fixed] - Fix compatibility issue for android 16 device
Pull Request resolved: facebook#22295

Differential Revision: D13084152

Pulled By: hramos

fbshipit-source-id: 42459ddc6f84f870affdda5ba19bcd8bb27b56d7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hey99xx hey99xx hey99xx left review comments

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@dulmandakh dulmandakh Awaiting requested review from dulmandakh

@hramos hramos Awaiting requested review from hramos

@elicwhite elicwhite Awaiting requested review from elicwhite

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Impact: Regression Describes a behavior that used to work on a prior release, but stopped working recently. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @hramos @react-native-bot @facebook-github-bot @hey99xx