Skip to content

Fix no-shadow eslint warning & remove var #22124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
binaryta wants to merge 1 commit into from
Closed

Fix no-shadow eslint warning & remove var #22124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions local-cli/link/ios/getGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

const getFirstProject = project => project.getFirstProject().firstProject;

const findGroup = (group, name) =>
group.children.find(group => group.comment === name);
const findGroup = (groups, name) =>
groups.children.find(group => group.comment === name);

/**
* Returns group from .xcodeproj if one exists, null otherwise
Expand All @@ -23,22 +23,22 @@ const findGroup = (group, name) =>
module.exports = function getGroup(project, path) {
const firstProject = getFirstProject(project);

var group = project.getPBXGroupByKey(firstProject.mainGroup);
let groups = project.getPBXGroupByKey(firstProject.mainGroup);

if (!path) {
return group;
return groups;
}

for (var name of path.split('/')) {
var foundGroup = findGroup(group, name);
var foundGroup = findGroup(groups, name);

if (foundGroup) {
group = project.getPBXGroupByKey(foundGroup.value);
groups = project.getPBXGroupByKey(foundGroup.value);
} else {
group = null;
groups = null;
break;
}
}

return group;
return groups;
};