-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back ImageEditingExample example #19972
Conversation
Woah, interesting find. It looks like this file got accidentally messed up in this commit: 4a80dce#diff-9bff2388f38e11550ff316a7e78092bd Instead of deleting this file could you add back the original version that was deleted in that commit? |
@TheSavior I add it back. I check the file git history and see it it empty in first place, not realizing that it was deleted accidentally :) |
Thanks! Can you confirm that it works in RNTester now? Also, it would be great if you migrated this file away from var to let/const. We have done that for most everything else in the codebase already but this file got missed since it was accidentally deleted. |
Currently I only have an windows computer, but RNTester doesn't work on windows see #19974. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was closed by @gengjiawen in 6dcadca. Once this commit is added to a release, you will see the corresponding version tag below the description at 6dcadca. If the commit has a single |
Summary: add back missing file. pass all current ci. none [GENERAL] [INTERNAL] [RNTester] - Add back ImageEditingExample example. Closes facebook/react-native#19972 Differential Revision: D8711888 Pulled By: TheSavior fbshipit-source-id: 14070bfbf747f7f59c4039981a9bc83c1c10862b
Motivation
add back missing file.
Test Plan
pass all current ci.
Related PRs
none
Release Notes
[GENERAL] [INTERNAL] [RNTester] - Add back ImageEditingExample example.