bump glog to 0.3.5 #19890
Closed
bump glog to 0.3.5 #19890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
✅Test Plan
Missing Changelog
|
@hramos please merge 😄 |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jun 27, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
approved these changes
Jun 27, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: bump glog to 0.3.5. Version 0.3.4 added support for libc++ or clang. Starting with revision 11, Android NDK recommends and defaults to clang, so it'll add support for it. notable changes in 0.3.4 and 0.3.5: * add libc++ support * reduce dynamic allocation from 3 to 1 per log message * style fix for C++11 * Add CMake support Closes facebook#19890 Differential Revision: D8662179 Pulled By: hramos fbshipit-source-id: ae2554d36e5b922e8649fc2ac7afc273a34cc127
hramos
pushed a commit
that referenced
this pull request
Jul 4, 2018
Summary: bump glog to 0.3.5. Version 0.3.4 added support for libc++ or clang. Starting with revision 11, Android NDK recommends and defaults to clang, so it'll add support for it. notable changes in 0.3.4 and 0.3.5: * add libc++ support * reduce dynamic allocation from 3 to 1 per log message * style fix for C++11 * Add CMake support Closes #19890 Differential Revision: D8662179 Pulled By: hramos fbshipit-source-id: ae2554d36e5b922e8649fc2ac7afc273a34cc127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump glog to 0.3.5.
Version 0.3.4 added support for libc++ or clang. Starting with revision 11, Android NDK recommends and defaults to clang, so it'll add support for it.
notable changes in 0.3.4 and 0.3.5:
Test Plan:
Builds and runs as usual