gradle to set project-wide properties #19845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Missing Test Plan
janicduplessis
approved these changes
Jun 27, 2018
|
@janicduplessis just resolved the conflict 👍 |
gengjiawen
suggested changes
Jun 27, 2018
| @@ -30,3 +30,11 @@ allprojects { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| ext { | |||
| buildToolsVersion = "26.0.2" | |||
There was a problem hiding this comment.
fixed, my bad :(
|
Any thought of bump the targetSdkVersion to 26 ? |
|
bumping targetSdk to 26, no need to touch minSdk because the app won't work on Android versions below minSdk. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jun 28, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Change HelloWorld app template to use project-wide properties. See https://developer.android.com/studio/build/gradle-tips#configure-project-wide-properties. RN community and third-party native module developers adopted this, so it'll make RN package development and usage easy. CI is green https://circleci.com/gh/dulmandakh/react-native/507 Closes facebook#19845 Differential Revision: D8675341 Pulled By: hramos fbshipit-source-id: 4ed06cd7ef7ae70f153d7f335ef8a9d1371f6ce0
hramos
pushed a commit
that referenced
this pull request
Jul 4, 2018
Summary: Change HelloWorld app template to use project-wide properties. See https://developer.android.com/studio/build/gradle-tips#configure-project-wide-properties. RN community and third-party native module developers adopted this, so it'll make RN package development and usage easy. CI is green https://circleci.com/gh/dulmandakh/react-native/507 Closes #19845 Differential Revision: D8675341 Pulled By: hramos fbshipit-source-id: 4ed06cd7ef7ae70f153d7f335ef8a9d1371f6ce0
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Change HelloWorld app template to use project-wide properties. See https://developer.android.com/studio/build/gradle-tips#configure-project-wide-properties. RN community and third-party native module developers adopted this, so it'll make RN package development and usage easy. CI is green https://circleci.com/gh/dulmandakh/react-native/507 Closes facebook/react-native#19845 Differential Revision: D8675341 Pulled By: hramos fbshipit-source-id: 4ed06cd7ef7ae70f153d7f335ef8a9d1371f6ce0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change HelloWorld app template to use project-wide properties. See https://developer.android.com/studio/build/gradle-tips#configure-project-wide-properties.
RN community and third-party native module developers adopted this, so it'll make RN package development and usage easy.
CI is green https://circleci.com/gh/dulmandakh/react-native/507