-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.53 stable #18016
0.53 stable #18016
Commits on Jan 10, 2018
-
Revert "Replace native cxx_library with fb-specific macros."
This reverts commit ba31d29.
Configuration menu - View commit details
-
Copy full SHA for aebb34a - Browse repository at this point
Copy the full SHA aebb34aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 796122d - Browse repository at this point
Copy the full SHA 796122dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c3a61f - Browse repository at this point
Copy the full SHA 7c3a61fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82b123e - Browse repository at this point
Copy the full SHA 82b123eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd46117 - Browse repository at this point
Copy the full SHA dd46117View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 49cbca7 - Browse repository at this point
Copy the full SHA 49cbca7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b99657 - Browse repository at this point
Copy the full SHA 0b99657View commit details
Commits on Jan 16, 2018
-
Fix HMR syntax error messages (
message
instead ofdescription
)Summary: The code to display HMR errors on the client was reading the `description` field from Metro payloads. Metro does not include `description` in the body of its error payloads -- only in its `body.errors[]` items. This commit changes RN's HMR code to show `body.message` (set consistently with facebook/metro#124) instead of the non-existent `body.description`. Open a test RN app, enable HMR, and then introduce a syntax error in an app source file. See that the redbox provides information about the syntax error instead of just saying "TransformError undefined". - facebook/metro#124 [GENERAL][ENHANCEMENT][HMR] - Fix display of syntax error messages when HMR is enabled Closes #17619 Differential Revision: D6726516 Pulled By: mjesun fbshipit-source-id: b1d1008d6f1aa8f88ff8a2aa1374724a305c773b
Configuration menu - View commit details
-
Copy full SHA for b4375b4 - Browse repository at this point
Copy the full SHA b4375b4View commit details
Commits on Jan 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 997bfb5 - Browse repository at this point
Copy the full SHA 997bfb5View commit details
Commits on Jan 31, 2018
-
Prevents JS Debugger issues with CORS
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> See #17618 On certain networks, `xip.io` is used, but as the debugger will always using localhost a change upstream has resulted in a CORS issue (see screenshots in #17618). This change ensures that the debugger will always open with whatever configuration. > This should be merged in as a patch of `0.52.x` as it affects current release, and `0.51.x` didn't have this issue. Tested locally, could do with the people having the same issue in #17618 testing it out prior to merging. (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> [CLI] [BUGFIX] [local-cli/server/middleware/getDevToolsMiddleware.js] - Prevents JS Debugger issues with CORS Closes #17720 Differential Revision: D6828205 Pulled By: hramos fbshipit-source-id: 7e5d43db9faf7edc9444ba4214aca1a18e25dbd2
Configuration menu - View commit details
-
Copy full SHA for df8da3b - Browse repository at this point
Copy the full SHA df8da3bView commit details -
Use boost-for-react-native CocoaPod
Summary: Use the same header-only distribution of Boost that Android and the automatic ios-install-third-party.sh script uses. Greatly speeds up `pod install`, even when the distribution was already cached. The dependency tree looks like this: * React * cxxreact subspec * **Boost** (versioned, 1.63.0) * Folly * **Boost** (any version, will resolve to 1.63.0 from above) Alternative implementation of PR #16756. Fixes issue #16381. (same as #16756) * Install react-native via Cocoapods (or move a helloWorld react-native application over to use Cocoapods for dependency management) * Add CxxBridge instead of BatchedBridge to your Podfile * run pod install * run react-native run-ios [Add boost.podspec speed up download time & reduce size of the package](#16756) [IOS] [BUGFIX] [third-party-podspecs] - optimize CocoaPods installation (Boost distribution) Closes #17476 Differential Revision: D6746095 Pulled By: hramos fbshipit-source-id: 55b2b5a698691f7fca0bf4c31c4376c2b9eb5379
Configuration menu - View commit details
-
Copy full SHA for cf19833 - Browse repository at this point
Copy the full SHA cf19833View commit details -
Make sure refreshControl shows up on initial render if specified
Summary: [this commit](2e1707d) which was just a small refactor broke refreshControl behavior - if we render FlatList with refreshing=true, the refreshControl won't be visible on initial render. The problem is, the [previous beginRefreshing method](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeL51) was renamed to `beginRefreshingProgramatically` and the old call was left in one place [here](2e1707d#diff-cfafa8d7e42ab87ab863f917e187a4aeR47). Now, I am not sure what kind of jumping the mentioned commit was fixing, but since this fix only concerns the initial render, I believe it will not influence the jumping fix. I have tested this locally in my app, can provide a video if needed. none [IOS] [BUGFIX] [RefreshControl] - Make sure refreshControl shows up on initial render if specified Closes #17727 Differential Revision: D6827402 Pulled By: shergin fbshipit-source-id: 25849244e87af54f25d636b6ade7adcf88958980
Configuration menu - View commit details
-
Copy full SHA for 9b877d6 - Browse repository at this point
Copy the full SHA 9b877d6View commit details
Commits on Feb 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f7bd2a3 - Browse repository at this point
Copy the full SHA f7bd2a3View commit details
Commits on Feb 6, 2018
-
Update React.podspec for RCTText
Summary: Some of the classes of RCTText are now in the subfolders, this will fix pod integration for texts <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> I have integrated React Native into my project with [this guide](https://facebook.github.io/react-native/docs/integration-with-existing-apps.html) and got the error `No component found for view with name RCTText`. Searching in the web did not give any useful information so I started to dig into the code and found out that there is now subfolders and pod taking only root classes. After making this change project started to compile again. Create empty project with pods integrated add `RCTText` subspec and in `.js` file add some `<Text>` element Fixed `RCTText` subspec integration. Closes #17655 Differential Revision: D6751039 Pulled By: hramos fbshipit-source-id: f4538d1125af2b45f36e2fa535382e032dbc8f4e
2Configuration menu - View commit details
-
Copy full SHA for 2c63f49 - Browse repository at this point
Copy the full SHA 2c63f49View commit details
Commits on Feb 14, 2018
-
Enable platforms to configure CLI commands
Summary: This change adds hooks via the `package.json` for a platform plugin to specify hooks for generating platform configurations. This change also adds hooks to allow platform plugins to participate in `link` and `unlink` commands. The goal is to move platform-specific code for platform plugins into their own repositories / node_modules. <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> We need to be able to configure the CLI commands for plugin platforms (e.g., react-native-windows) in their own repositories. (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) - All jest tests, including new tests, pass. - `link` and `unlink` commands are successful on iOS and Android. (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.) microsoft/react-native-windows#1601 <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> [CLI][FEATURE][local-cli/core/index.js] - Allow platform plugins to contribute to the RNConfig. [CLI][FEATURE][local-cli/link/link.js] - Allow platform plugins to participate in the `link` command. [CLI][FEATURE][local-cli/link/unlink.js] - Allow platform plugins to participate in the `unlink` command. Closes #17745 Differential Revision: D6883558 Pulled By: hramos fbshipit-source-id: ea32fe21cedd4cc02c5c0d48229f2cdb2ac8142b
Configuration menu - View commit details
-
Copy full SHA for 9775308 - Browse repository at this point
Copy the full SHA 9775308View commit details -
Uses a single code path to link and unlink all platforms
Summary: This commit removes special cases for linking iOS and Android platforms. A previous commit opened up link and other commands for other platforms to provide their own behaviors. It left special cases in tact for iOS and Android. This PR removes the special case. - Added jest tests related to the link command. - Ran the `link` and `unlink` commands for iOS and Android and confirmed no changes. #17745 <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> [CLI][FEATURE][local-cli/link/link.js] - Removes special cases for linking in iOS and Android. Closes #17961 Differential Revision: D6975951 Pulled By: hramos fbshipit-source-id: 8dd5da35619e2124ce4b3b18db8b694757792363
Configuration menu - View commit details
-
Copy full SHA for 2f70001 - Browse repository at this point
Copy the full SHA 2f70001View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7f400f - Browse repository at this point
Copy the full SHA f7f400fView commit details