Skip to content

Change android assets names #16739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vovanmozg wants to merge 4 commits into from
Closed

Change android assets names #16739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df3b7c8
change android assets filenames
vovanmozg Nov 7, 2017
c02b8e7
Merge branch 'master' into android-assets-names
vovanmozg Mar 16, 2018
e2586ed
Merge branch 'master' into android-assets-names
vovanmozg Jun 18, 2018
68c03ba
Merge branch 'master' into android-assets-names
vovanmozg Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions local-cli/bundle/assetPathUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
'use strict';

import type {PackagerAsset} from '../../Libraries/Image/AssetRegistry';
import md5 from 'md5';

/**
* FIXME: using number to represent discrete scale numbers is fragile in essence because of
Expand Down Expand Up @@ -62,11 +63,7 @@ function getAndroidResourceFolderName(asset: PackagerAsset, scale: number) {

function getAndroidResourceIdentifier(asset: PackagerAsset) {
var folderPath = getBasePath(asset);
return (folderPath + '/' + asset.name)
.toLowerCase()
.replace(/\//g, '_') // Encode folder structure in file name
.replace(/([^a-z0-9_])/g, '') // Remove illegal chars
.replace(/^assets_/, ''); // Remove "assets_" prefix
return 'a' + md5(folderPath + '/' + asset.name).toLowerCase();
}

function getBasePath(asset: PackagerAsset) {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@
"graceful-fs": "^4.1.3",
"inquirer": "^3.0.6",
"lodash": "^4.17.5",
"md5": "^2.2.1",
"metro": "^0.42.1",
"metro-babel-register": "^0.42.1",
"metro-core": "^0.42.1",
Expand Down