Skip to content

Move showcase source data into a JSON file #12626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hramos wants to merge 4 commits into from
Closed

Move showcase source data into a JSON file #12626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
988e71d
Load Showcase from a single file
hramos Feb 27, 2017
a691c16
Move showcase config to JSON file.
hramos Feb 28, 2017
d9b4aea
Add guidelines
hramos Feb 28, 2017
56ea805
Merge branch 'master' into showcase-tests
hramos Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions website/server/convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ function execute(options) {

var DOCS_MD_DIR = '../docs/';
var BLOG_MD_DIR = '../blog/';
var CONFIG_JSON_DIR = '../';

glob.sync('src/react-native/docs/*.*').forEach(rmFile);
glob.sync('src/react-native/blog/*.*').forEach(rmFile);
Expand Down Expand Up @@ -179,6 +180,13 @@ function execute(options) {
metadatas.config[key] = process.env[key];
});

// load showcase apps into metadata
var showcaseApps = JSON.parse(fs.readFileSync(
Copy link
Contributor

@ericvicenti ericvicenti Feb 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in other codebases we would want flow types, but nevermind here 😄

path.basename(CONFIG_JSON_DIR + 'showcase.json'),
{encoding: 'utf8'}
));
metadatas.showcaseApps = showcaseApps;

fs.writeFileSync(
'core/metadata.js',
'/**\n' +
Expand Down
Loading