Document AsyncStorage size on iOS and Android

[ericpalakovichcarr]

Currently, there's no documentation on the default 6MB limit on Android for AsyncStorage. This pull request adds documentation for iOS and Android size limits, as well as example code for changing the default size limit on Android.

This pull request should properly resolve this issue: #3387 (comment)

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @caabernathy and @davidaurelio to be potential reviewers.

[eslint-bot]

no-trailing-spaces: Trailing spaces not allowed.

[nihgwu]

nice job

[mkonicek]

Thanks for adding docs for this!

nit: getPackages as the name says is meant to return a list of packages. How about adding the code in onCreate in the MainActivity? See https://developer.android.com/reference/android/app/Activity.html

Does that work?

[mkonicek]

In case Activity.onCreate is too early (calling the code there crashes), overriding this method in the Application by calling super and then the extra code should work: https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java#L65

[ericpalakovichcarr]

@mkonicek Looks like both will work. Would you prefer one over the other? I'll just update the code for onCreate otherwise.

[ericpalakovichcarr]

I'll just say that onCreate makes sense to me given the method is already defined in the boilerplate code generated by react-native init.

[ericpalakovichcarr]

Whoops, I accidentally submitted the commit with the onCreate change. Let me know if you'd like to see the createReactInstanceManager method used instead.

[ericpalakovichcarr]

Is there anything else that needs to happen here on my end? Just checking if the ticket is stuck because of me or not.

[ericpalakovichcarr]

@mkonicek Is this pull request still waiting on me for something? Or do pull requests just sit in limbo for a while at times? (which is totally ok for me!)

[adrianha]

hi @BigSassy, i already following your suggestion to update AsyncStorage's limit by modifying onCreate method but its still not working. Any idea? I'm using RN v0.40. Thank you

[ericpalakovichcarr]

@adrianha Could you paste the code for your onCreate method here? I have no idea otherwise. And you're doing this in MainApplication.java right? Not MainActivity.java?

[kennethpdev]

@BigSassy

Here's my code on the onCreate with the latest stable version of react-native 0.42.3.

  @Override
  public void onCreate() {
    super.onCreate();
    SoLoader.init(this, false);

    // Increase the maximum size of AsyncStorage
    long size = 50L * 1024L * 1024L; // 50 MB
    ReactDatabaseSupplier.getInstance(getApplicationContext()).setMaximumSize(size);
  }

I want to increase it to have at least 50MB in size. This doesn't seem to work. I added it inside MainApplication.java. Also is there a difference by settings 50L or just 50 on the size? The original size they wrote it to 6L. Tho, changing this doesn't affect anything. AsyncStorage still not expanding for some reason.

Regards,

[facebook-github-bot]

@BigSassy I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

[RobIsHere]

Is this information outdated? Or why hasn't this been merged or closed normally? Having information about the limits of a system is really important for understanding its possible field of application.

Other people fall into your trap for sure! The ones who aren't that experienced and do neither anticipate nor research things like these! Caring about them costs only as much time as one click on the merge button, isn't it...?

[hramos]

There's hundreds of pull requests open and we're slowly working through them. Ideally this would have been flagged by a community member after the stale bot posted the first warning. We'll see how we can improve the process.

[facebook-github-bot]

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[hramos]

Heads up - the docs are now at https://github.com/facebook/react-native-website

You may want to make the same change over there. Sorry for the unnecessary work here, we're still in the process of landing the commits that will remove the duplicate docs from this repo. Thanks for your contribution!