BREAKING: Android - ReactNativeHost getUseDeveloperSupport to public #2 #11505
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DevSupportPublic * upstream/master: Allow configuring the way CLI installs react-native
…DevSupportPublic * upstream/master: Rename directories Use absolute paths from repo root Remove init from api CLI: Show npm / yarn output during 'react-native-init' when installing React and Jest
* master: Implement onViewAppear by creating a new EventListener on ReactRootView listening for when it's attached to a RN Instance
|
By analyzing the blame information on this pull request, we identified @foghina and @funorpain to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
Import Started
|
@AaaChiuuu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
aaronechiu
approved these changes
Dec 16, 2016
|
@AaaChiuuu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
GH Review: accepted
CLA Signed
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: AaaChiuuu See: facebook#11329 Closes facebook#11505 Differential Revision: D4338559 Pulled By: AaaChiuuu fbshipit-source-id: 6cd1fd366a2bc30d496b7e907242e7f89a384a19
|
@AaaChiuuu This didn't make it into 0.40.0, is it slated for 0.41.0? Disregard, just saw: https://github.com/facebook/react-native/releases/tag/v0.41.0-rc.0 |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Feb 7, 2017
Summary: AaaChiuuu See: facebook/react-native#11329 Closes facebook/react-native#11505 Differential Revision: D4338559 Pulled By: AaaChiuuu fbshipit-source-id: 6cd1fd366a2bc30d496b7e907242e7f89a384a19
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: AaaChiuuu See: facebook/react-native#11329 Closes facebook/react-native#11505 Differential Revision: D4338559 Pulled By: AaaChiuuu fbshipit-source-id: 6cd1fd366a2bc30d496b7e907242e7f89a384a19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AaaChiuuu
See: #11329