Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update releases to refer to month instead of two weeks #11269

Closed
wants to merge 1 commit into from

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Dec 2, 2016

We also have to update internal guides.

CC: @mkonicek

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @satya164 to be a potential reviewer.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Dec 2, 2016
@satya164
Copy link
Contributor

satya164 commented Dec 2, 2016

@facebook-github-bot shipit

@mkonicek
Copy link
Contributor

mkonicek commented Dec 2, 2016

@grabbou @satya164 1st of January might be ambitious given it's the New Year's Day? :)

In general hitting the exact date every month might be difficult. How about saying "within first few days of each month"?

@mkonicek
Copy link
Contributor

mkonicek commented Dec 2, 2016

@satya164 Not sure why the bot didn't work :/

@mkonicek
Copy link
Contributor

mkonicek commented Dec 2, 2016

This landed internally but exporting back to GitHub failed.

@fredemmott
Copy link
Contributor

It got exported to github: 830d7f6

Closing because this PR has been merged, github just doesn't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants